diff options
| author | Nicolas Lempereur <nle@odoo.com> | 2021-02-22 17:37:40 +0000 |
|---|---|---|
| committer | Nicolas Lempereur <nle@odoo.com> | 2021-02-22 17:45:52 +0000 |
| commit | 96c22e816981d72c185520750167c514c6bded5b (patch) | |
| tree | 15b3ee1a57c56c370de3861c0fc586915f122e73 /addons/web_editor/static/src/js | |
| parent | ff534c65486970b4ebe731c22e8954390a6cc31c (diff) | |
[FIX] web_editor: can set bg position on root editor
Scenario:
- go to /slides and start editing the page
- change the position of background banner
- save
=> traceback
Why:
The code for pan tool duplicates the target element in an overlay. In
the given use case, it means a node with .o_editable class is created
that will cause an error when saving because the code expect the cloned
element to be an editor (in `RTEWidget.save()`) but it is not (and is
eg. missing `.data('options')`).
opw-2427560
closes odoo/odoo#66639
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
Diffstat (limited to 'addons/web_editor/static/src/js')
| -rw-r--r-- | addons/web_editor/static/src/js/editor/snippets.options.js | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/addons/web_editor/static/src/js/editor/snippets.options.js b/addons/web_editor/static/src/js/editor/snippets.options.js index cbf8ffb7b6b..621cd9b4d6f 100644 --- a/addons/web_editor/static/src/js/editor/snippets.options.js +++ b/addons/web_editor/static/src/js/editor/snippets.options.js @@ -4342,6 +4342,8 @@ registry.BackgroundPosition = SnippetOptionWidget.extend({ // Create empty clone of $target with same display size, make it draggable and give it a tooltip. this.$bgDragger = this.$target.clone().empty(); + // Prevent clone from being seen as editor if target is editor (eg. background on root tag) + this.$bgDragger.removeClass('o_editable'); // Some CSS child selector rules will not be applied since the clone has a different container from $target. // The background-attachment property should be the same in both $target & $bgDragger, this will keep the // preview more "wysiwyg" instead of getting different result when bg position saved (e.g. parallax snippet) |
