diff options
| author | Samuel Degueldre <sad@odoo.com> | 2020-09-07 11:22:45 +0000 |
|---|---|---|
| committer | Samuel Degueldre <sad@odoo.com> | 2020-09-11 15:03:41 +0000 |
| commit | 14b05235b8b6cec6fbee44bea03b47852d9a513c (patch) | |
| tree | 6e06f6de23203fd18c39d98ce443f58fce727ac3 /addons/web_editor/static/src/js/editor/snippets.options.js | |
| parent | 960e61e7451ef8dacd3aaa70bb148240762ab461 (diff) | |
[FIX] web_editor: do not display quality options on SVGs/GIFs
When the width and quality option for images was moved from the
optimize-dialog to the left-panel, it was made available on all image
types. However, width and quality options don't make sense on SVGs and
would break animated gifs. This commit makes it so that quality options
are only available on JPEG and PNG images.
closes odoo/odoo#57561
X-original-commit: 315be6f4765268eada4b39a637136c86a30720eb
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
Diffstat (limited to 'addons/web_editor/static/src/js/editor/snippets.options.js')
| -rw-r--r-- | addons/web_editor/static/src/js/editor/snippets.options.js | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/addons/web_editor/static/src/js/editor/snippets.options.js b/addons/web_editor/static/src/js/editor/snippets.options.js index 5b7aba79184..8e236bb93d1 100644 --- a/addons/web_editor/static/src/js/editor/snippets.options.js +++ b/addons/web_editor/static/src/js/editor/snippets.options.js @@ -3109,7 +3109,11 @@ const ImageHandlerOption = SnippetOptionWidget.extend({ * @override */ _computeVisibility() { - const src = this._getImg().getAttribute('src'); + const img = this._getImg(); + if (!['image/jpeg', 'image/png'].includes(img.dataset.mimetype)) { + return false; + } + const src = img.getAttribute('src'); return src && src !== '/'; }, /** |