[FIX] web_editor: properly not allow edition of non editable parts

Before this commit, (double) clicking an image/link in a non editable
environment still opened a dialog / change the editor bar for edition.

1 files changed, 12 insertions, 3 deletions

diff --git a/addons/web_editor/static/src/js/editor/rte.summernote.js b/addons/web_editor/static/src/js/editor/rte.summernote.js
index 01b83530e48..141fb6ea229 100644
--- a/addons/web_editor/static/src/js/editor/rte.summernote.js
+++ b/addons/web_editor/static/src/js/editor/rte.summernote.js
@@ -771,7 +771,7 @@ eventHandler.attach = function (oLayoutInfo, options) {
         });
     }
     oLayoutInfo.editable().on('mousedown', function (e) {
-        if (dom.isImg(e.target)) {
+        if (dom.isImg(e.target) && dom.isContentEditable(e.target)) {
             range.createFromNode(e.target).select();
         }
     });
@@ -836,7 +836,12 @@ eventHandler.attach = function (oLayoutInfo, options) {
         var show_tooltip = true;
 
         oLayoutInfo.editor().on("dblclick", selector, function (e) {
-            if ($(e.target).closest(".note-toolbar").length) return; // prevent icon edition of top bar for default summernote
+            var $target = $(e.target);
+            if (!dom.isContentEditable($target)) {
+                // Prevent edition of non editable parts
+                return;
+            }
+
             show_tooltip = false;
             callback();
             e.stopImmediatePropagation();
@@ -844,7 +849,11 @@ eventHandler.attach = function (oLayoutInfo, options) {
 
         oLayoutInfo.editor().on("click", selector, function (e) {
             var $target = $(e.target);
-            if ($target.closest(".note-toolbar").length) return; // prevent icon edition of top bar for default summernote
+            if (!dom.isContentEditable($target)) {
+                // Prevent edition of non editable parts
+                return;
+            }
+
             show_tooltip = true;
             setTimeout(function () {
                 if (!show_tooltip) return;