diff options
| author | jvm-odoo <jvm@odoo.com> | 2020-05-06 07:00:35 +0000 |
|---|---|---|
| committer | jvm-odoo <jvm@odoo.com> | 2020-05-12 08:28:27 +0000 |
| commit | 3a11b9e757d0b649f434f78eec2cd35b52e27a28 (patch) | |
| tree | cb955ff99b9051d7f242218fb32eb3359f9bd071 /addons/web | |
| parent | e3c303e6cb7274a6c257194cca011e473d9f3028 (diff) | |
[FIX] web: fix statusbar option conversion
Issue
- Install Projects
- All Tasks > Form View
- Edit the view
- Set statusbar clickable to '0'
Still clickable
Cause
In relational_field.js we do
`!!'0'` which returns true
like `!!'anythingelse'`
Solution
Add a '+' which will convert
the value into an integer
for a better conversion.
OPW-2235311
closes odoo/odoo#51083
X-original-commit: 53cc68fce32f46a0b4bc83a1e73a5d13a60fc995
Signed-off-by: Jason Van Malder (jvm) <jvm@odoo.com>
Diffstat (limited to 'addons/web')
| -rw-r--r-- | addons/web/static/src/js/fields/relational_fields.js | 6 | ||||
| -rw-r--r-- | addons/web/static/tests/views/form_tests.js | 2 |
2 files changed, 6 insertions, 2 deletions
diff --git a/addons/web/static/src/js/fields/relational_fields.js b/addons/web/static/src/js/fields/relational_fields.js index 83bc4c8a7f0..944a7c30ebb 100644 --- a/addons/web/static/src/js/fields/relational_fields.js +++ b/addons/web/static/src/js/fields/relational_fields.js @@ -2767,7 +2767,11 @@ var FieldStatus = AbstractField.extend({ // Retro-compatibility: clickable used to be defined in the field attrs // instead of options. // If not set, the statusbar is not clickable. - this.isClickable = !!this.attrs.clickable || !!this.nodeOptions.clickable; + try { + this.isClickable = !!JSON.parse(this.attrs.clickable); + } catch (_) { + this.isClickable = !!this.nodeOptions.clickable; + } }, //-------------------------------------------------------------------------- diff --git a/addons/web/static/tests/views/form_tests.js b/addons/web/static/tests/views/form_tests.js index 3427244881b..77b684eeedf 100644 --- a/addons/web/static/tests/views/form_tests.js +++ b/addons/web/static/tests/views/form_tests.js @@ -6868,7 +6868,7 @@ QUnit.module('Views', { model: 'partner', data: this.data, arch: '<form>' + - '<header><field name="trululu" widget="statusbar" clickable="True"/></header>' + + '<header><field name="trululu" widget="statusbar" clickable="true"/></header>' + '</form>', res_id: 1, mockRPC: function (route, args) { |