diff options
| author | Damien Abeloos <abd@odoo.com> | 2021-01-08 16:56:35 +0000 |
|---|---|---|
| committer | Damien Abeloos <abd@odoo.com> | 2021-01-08 17:35:37 +0000 |
| commit | 892598cb0335926ece12789d81673f5b6370a1fd (patch) | |
| tree | d695b4357b791682f6fc2c3ded61a874fd73189e /addons/web/views | |
| parent | 745d7a1b018d42ba317b23efe7646339a1a63ad4 (diff) | |
[FIX] web: fix the RedirectWarningHandler dialog not closing
Impacted versions :
- 14.0 and higher
Steps to reproduce :
```
1. generate an odoo.exceptions.RedirectWarning
2. click on the primary button
```
Current behavior :
```
1. the action (argument of the RedirectWarning) is properly executed
2. the WarningDialog is not closed
```
Expected behavior :
```
1. the action should still be properly executed
2. the WarningDialog should be closed
```
Tests :
Added a test to ensure this behavior will not be overwritten in the future.
The test is for the CrashManager service, and evaluates the following sequence :
```
Entry: CrashManager receives a odoo.exceptions.RedirectWarning (code 200) via rpc_error
Asserts:
- The RedirectWarning modal (WarningDialog) should be opened
* Upon clicking on the primary button :
- The modal should be closed
- The action passed as an argument of the odoo.exceptions.RedirectWarning should be executed
```
Origin :
the incorrect behavior was introduced with :
https://github.com/odoo/odoo/commit/b3d9647695065ea582e4a6b0603f3ebf9fde6976
Task ID: 2430100
closes odoo/odoo#64290
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Diffstat (limited to 'addons/web/views')
| -rw-r--r-- | addons/web/views/webclient_templates.xml | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/addons/web/views/webclient_templates.xml b/addons/web/views/webclient_templates.xml index 28584f248c1..3ba5f091cad 100644 --- a/addons/web/views/webclient_templates.xml +++ b/addons/web/views/webclient_templates.xml @@ -698,6 +698,7 @@ <script type="text/javascript" src="/web/static/tests/qweb_tests.js"></script> <script type="text/javascript" src="/web/static/tests/mockserver_tests.js"></script> + <script type="text/javascript" src="/web/static/tests/services/crash_manager_tests.js"></script> <script type="text/javascript" src="/web/static/tests/services/data_manager_tests.js"></script> <script type="text/javascript" src="/web/static/tests/services/notification_service_tests.js"></script> |