[MERGE] forward port branch saas-11.3 up to 1e0a92c9962

6 files changed, 9 insertions, 119 deletions

diff --git a/addons/web/static/src/js/chrome/abstract_web_client.js b/addons/web/static/src/js/chrome/abstract_web_client.js
index bce77a352ea..45013858e1b 100644
--- a/addons/web/static/src/js/chrome/abstract_web_client.js
+++ b/addons/web/static/src/js/chrome/abstract_web_client.js
@@ -182,7 +182,9 @@ var AbstractWebClient = Widget.extend(ServiceProviderMixin, KeyboardNavigationMi
             // If it is not handled, we should display something clearer than the common crash_manager error dialog
             // since it won't show anything except "Script error."
             // This link will probably explain it better: https://blog.sentry.io/2016/05/17/what-is-script-error.html
-            if (message === "Script error." && !file && !line && !col && !error) {
+            if (!file && !line && !col) {
+                // Chrome and Opera set "Script error." on the `message` and hide the `error`
+                // Firefox handles the "Script error." directly. It sets the error thrown by the CORS file into `error`
                 if (window.onOriginError) {
                     window.onOriginError();
                     delete window.onOriginError;
@@ -190,7 +192,7 @@ var AbstractWebClient = Widget.extend(ServiceProviderMixin, KeyboardNavigationMi
                     crash_manager.show_error({
                         type: _t("Odoo Client Error"),
                         message: _t("Unknown CORS error"),
-                        data: {debug: _t("An unknown CORS error occured. The error probably originates from a JavaScript file served from a different origin.")},
+                        data: {debug: _t("An unknown CORS error occured. The error probably originates from a JavaScript file served from a different origin. (Opening your browser console might give you a hint on the error.)")},
                     });
                 }
             } else {
diff --git a/addons/web/static/src/js/views/kanban/kanban_model.js b/addons/web/static/src/js/views/kanban/kanban_model.js
index 5d606324023..0328ff1e0e6 100644
--- a/addons/web/static/src/js/views/kanban/kanban_model.js
+++ b/addons/web/static/src/js/views/kanban/kanban_model.js
@@ -61,15 +61,11 @@ var KanbanModel = BasicModel.extend({
         if (!groupByField || groupByField.type !== 'many2one') {
             return $.Deferred().reject(); // only supported when grouped on m2o
         }
-        // ignore action default which may be for another model
-        var context = _.pick(parent.context, function (value, key) {
-            return key.slice(0,8) !== 'default_';
-        });
         return this._rpc({
                 model: groupByField.relation,
                 method: 'name_create',
                 args: [name],
-                context: context, // todo: combine with view context
+                context: parent.context, // todo: combine with view context
             })
             .then(function (result) {
                 var newGroup = self._makeDataPoint({
diff --git a/addons/web/static/src/js/views/list/list_renderer.js b/addons/web/static/src/js/views/list/list_renderer.js
index 682b98f82fe..76ad3a82063 100644
--- a/addons/web/static/src/js/views/list/list_renderer.js
+++ b/addons/web/static/src/js/views/list/list_renderer.js
@@ -193,6 +193,7 @@ var ListRenderer = BasicRenderer.extend({
                 reject = columnInvisibleFields[c.attrs.name];
             }
             if (!reject && c.attrs.widget === 'handle') {
+                self.hasHandle = true;
                 self.handleField = c.attrs.name;
             }
             return reject;
@@ -656,8 +657,6 @@ var ListRenderer = BasicRenderer.extend({
         this._computeAggregates();
         $table.toggleClass('o_list_view_grouped', is_grouped);
         $table.toggleClass('o_list_view_ungrouped', !is_grouped);
-        this.hasHandle = this.state.orderedBy.length === 0 ||
-            this.state.orderedBy[0].name === this.handleField;
         if (is_grouped) {
             $table
                 .append(this._renderHeader(true))
diff --git a/addons/web/static/tests/chrome/action_manager_tests.js b/addons/web/static/tests/chrome/action_manager_tests.js
index e0bb22c0bb4..3a776a73a28 100644
--- a/addons/web/static/tests/chrome/action_manager_tests.js
+++ b/addons/web/static/tests/chrome/action_manager_tests.js
@@ -1907,7 +1907,7 @@ QUnit.module('ActionManager', {
             start: function () {
                 var self = this;
                 return this._super.apply(this, arguments).then(function () {
-                    self.iframe.src = 'test: ' + self.iframe.getAttribute('src');
+                    self.iframe.src = 'test ' + self.iframe.getAttribute('src');
                 });
             }
         });
@@ -1926,7 +1926,7 @@ QUnit.module('ActionManager', {
                 if (route === '/report/check_wkhtmltopdf') {
                     return $.when('broken');
                 }
-                if (route === 'test: /report/html/some_report') {
+                if (route === 'test /report/html/some_report') {
                     return $.when();
                 }
                 return this._super.apply(this, arguments);
@@ -1947,7 +1947,7 @@ QUnit.module('ActionManager', {
             '/web/action/load',
             '/report/check_wkhtmltopdf',
             'notification',
-            'test: /report/html/some_report', // report client action's iframe
+            'test /report/html/some_report', // report client action's iframe
         ]);
 
         actionManager.destroy();
diff --git a/addons/web/static/tests/views/kanban_tests.js b/addons/web/static/tests/views/kanban_tests.js
index 8c73dcc21e9..7680d8877b1 100644
--- a/addons/web/static/tests/views/kanban_tests.js
+++ b/addons/web/static/tests/views/kanban_tests.js
@@ -1157,43 +1157,6 @@ QUnit.module('Views', {
         kanban.destroy();
     });
 
-    QUnit.test('m2o group record created does not use action defaults', function (assert) {
-        assert.expect(1);
-
-        var kanban = createView({
-            View: KanbanView,
-            model: 'partner',
-            data: this.data,
-            arch: '<kanban class="o_kanban_test" on_create="quick_create">' +
-                        '<templates><t t-name="kanban-box">' +
-                            '<div>' +
-                                '<field name="foo"/>' +
-                            '</div>' +
-                        '</t></templates>' +
-                    '</kanban>',
-            groupBy: ['product_id'],
-            mockRPC: function (route, args) {
-                if (args.method === 'name_create') {
-                    assert.notOk(_.has(args.kwargs.context, 'default_name'),
-                        "default_* should be removed from context");
-                }
-                return this._super.apply(this, arguments);
-            },
-            viewOptions: {
-                context: {
-                    default_name: 'default name partner',
-                },
-            },
-        });
-        kanban.renderButtons();
-
-        kanban.$('.o_column_quick_create input').val('new product');
-        kanban.$('.o_column_quick_create button.o_kanban_add').click();
-
-        kanban.destroy();
-    });
-
-
     QUnit.test('quick create record fail in grouped', function (assert) {
         assert.expect(7);
 
diff --git a/addons/web/static/tests/views/list_tests.js b/addons/web/static/tests/views/list_tests.js
index 9f476a6f1c9..a6b28ed24e7 100644
--- a/addons/web/static/tests/views/list_tests.js
+++ b/addons/web/static/tests/views/list_tests.js
@@ -3235,76 +3235,6 @@ QUnit.module('Views', {
         list.destroy();
     });
 
-    QUnit.test('editable list, handle widget locks and unlocks on sort', function (assert) {
-        assert.expect(6);
-
-        // we need another sortable field to lock/unlock the handle
-        this.data.foo.fields.amount.sortable = true;
-        // resequence makes sense on a sequence field, not on arbitrary fields
-        this.data.foo.records[0].int_field = 0;
-        this.data.foo.records[1].int_field = 1;
-        this.data.foo.records[2].int_field = 2;
-        this.data.foo.records[3].int_field = 3;
-
-        var list = createView({
-            View: ListView,
-            model: 'foo',
-            data: this.data,
-            arch: '<tree editable="top" default_order="int_field">' +
-                    '<field name="int_field" widget="handle"/>' +
-                    '<field name="amount" widget="float"/>' +
-                  '</tree>',
-        });
-
-        assert.strictEqual(list.$('tbody').text(), '1200.00500.00300.000.00',
-            "default should be sorted by int_field");
-
-        // Drag and drop the fourth line in second position
-        testUtils.dragAndDrop(
-            list.$('.ui-sortable-handle').eq(3),
-            list.$('tbody tr').first(),
-            {position: 'bottom'}
-        );
-
-        // Handle should be unlocked at this point
-        assert.strictEqual(list.$('tbody').text(), '1200.000.00500.00300.00',
-            "drag and drop should have succeeded, as the handle is unlocked");
-
-        // Sorting by a field different for int_field should lock the handle
-        list.$('.o_column_sortable').eq(1).click();
-
-        assert.strictEqual(list.$('tbody').text(), '0.00300.00500.001200.00',
-            "should have been sorted by amount");
-
-        // Drag and drop the fourth line in second position (not)
-        testUtils.dragAndDrop(
-            list.$('.ui-sortable-handle').eq(3),
-            list.$('tbody tr').first(),
-            {position: 'bottom'}
-        );
-
-        assert.strictEqual(list.$('tbody').text(), '0.00300.00500.001200.00',
-            "drag and drop should have failed as the handle is locked");
-
-        // Sorting by int_field should unlock the handle
-        list.$('.o_column_sortable').eq(0).click();
-
-        assert.strictEqual(list.$('tbody').text(), '1200.000.00500.00300.00',
-            "records should be ordered as per the previous resequence");
-
-        // Drag and drop the fourth line in second position
-        testUtils.dragAndDrop(
-            list.$('.ui-sortable-handle').eq(3),
-            list.$('tbody tr').first(),
-            {position: 'bottom'}
-        );
-
-        assert.strictEqual(list.$('tbody').text(), '1200.00300.000.00500.00',
-            "drag and drop should have worked as the handle is unlocked");
-
-        list.destroy();
-    });
-
     QUnit.test('editable list with handle widget with slow network', function (assert) {
         assert.expect(15);