[FIX] web: display empty input fields properly

Before this commit, it was not possible to see the difference between an
unset float field (with a 'false' value) and a set field (for ex, with
value 0)

This was due to the fact that the formatFloat/formatMonetary functions
format false values as the number 0, unlike many other formatting
functions.

2 files changed, 17 insertions, 10 deletions

diff --git a/addons/web/static/tests/fields/basic_fields_tests.js b/addons/web/static/tests/fields/basic_fields_tests.js
index f2334b61f4a..6e007949ea7 100644
--- a/addons/web/static/tests/fields/basic_fields_tests.js
+++ b/addons/web/static/tests/fields/basic_fields_tests.js
@@ -415,9 +415,9 @@ QUnit.module('basic_fields', {
                   '</tree>',
         });
 
-        var zeroValues = list.$('td').filter(function () {return $(this).text() === '0.000';});
-        assert.strictEqual(zeroValues.length, 2,
-            'Unset float values should be rendered as zeros.');
+        var zeroValues = list.$('td.o_data_cell').filter(function () {return $(this).text() === '';});
+        assert.strictEqual(zeroValues.length, 1,
+            'Unset float values should be rendered as empty strings.');
 
         // switch to edit mode
         var $cell = list.$('tr.o_data_row td:not(.o_list_record_selector)').first();
@@ -441,8 +441,8 @@ QUnit.module('basic_fields', {
     QUnit.test('do not trigger a field_changed if they have not changed', function (assert) {
         assert.expect(2);
 
-        this.data.partner.records[1].qux = undefined;
-        this.data.partner.records[1].int_field = undefined;
+        this.data.partner.records[1].qux = false;
+        this.data.partner.records[1].int_field = false;
         var form = createView({
             View: FormView,
             model: 'partner',
@@ -1659,9 +1659,9 @@ QUnit.module('basic_fields', {
         assert.strictEqual(euroValues.length, 1,
             'One one line has euro as a currency.');
 
-        var zeroValues = list.$('td').filter(function () {return _.str.include($(this).text(), '0.00');});
-        assert.strictEqual(zeroValues.length, 2,
-            'Unset float values should be rendered as zeros.');
+        var zeroValues = list.$('td.o_data_cell').filter(function () {return $(this).text() === '';});
+        assert.strictEqual(zeroValues.length, 1,
+            'Unset float values should be rendered as empty strings.');
 
         // switch to edit mode
         var $cell = list.$('tr.o_data_row td:not(.o_list_record_selector):contains($)');
diff --git a/addons/web/static/tests/fields/field_utils_tests.js b/addons/web/static/tests/fields/field_utils_tests.js
index d56f077b828..bfd60000035 100644
--- a/addons/web/static/tests/fields/field_utils_tests.js
+++ b/addons/web/static/tests/fields/field_utils_tests.js
@@ -23,13 +23,13 @@ QUnit.test('format integer', function(assert) {
     assert.strictEqual(fieldUtils.format.integer(106500), '106,50,0');
 
     assert.strictEqual(fieldUtils.format.integer(0), "0");
-    assert.strictEqual(fieldUtils.format.integer(undefined), "");
+    assert.strictEqual(fieldUtils.format.integer(false), "");
 
     core._t.database.parameters.grouping = originalGrouping;
 });
 
 QUnit.test('format float', function(assert) {
-    assert.expect(4);
+    assert.expect(5);
 
     var originalParameters = $.extend(true, {}, core._t.database.parameters);
 
@@ -48,6 +48,7 @@ QUnit.test('format float', function(assert) {
         thousands_sep: '.'
     });
     assert.strictEqual(fieldUtils.format.float(6000), '6.000,00');
+    assert.strictEqual(fieldUtils.format.float(false), '');
 
     core._t.database.parameters = originalParameters;
 });
@@ -70,6 +71,12 @@ QUnit.test("format_many2one", function (assert) {
     }));
 });
 
+QUnit.test('format monetary', function(assert) {
+    assert.expect(1);
+
+    assert.strictEqual(fieldUtils.format.monetary(false), '');
+});
+
 QUnit.test('format char', function(assert) {
     assert.expect(1);