summaryrefslogtreecommitdiff
path: root/addons/web/static/tests/fields/basic_fields_tests.js
diff options
context:
space:
mode:
authorAaron Bohy <aab@odoo.com>2018-08-23 09:50:12 +0200
committerAaron Bohy <aab@odoo.com>2018-08-23 16:18:32 +0200
commitf6e5bd13d497bfadf24cf4a3639b4dabb14708da (patch)
tree6066acfadd5a9ac498edf0533da94a070183cc04 /addons/web/static/tests/fields/basic_fields_tests.js
parent3f2bc7b11f0247ac8e681c2403c16ab9f1d7972a (diff)
[FIX] web: Kanban QuickCreate: create on 'ENTER'
Rev. 241704536d3 highlighted a bug in the Kanban RecordQuickCreate widget, when a form view is used inside the widget. Let's assume a quick create form view with a char field. The user fill in this field and press 'ENTER' (without focusing out). The record is about to be created. But first, we have to ask all fields to commit their value (through 'commitChanges'), in case they wouldn't have yet. The char field thus notifies its parents of its new value at that moment. The form controller handles this request in its '_applyChanges' function, but this is done in its mutex (to prevent overlapping onchange RPCs). Unfortunately, this leads to a deadlock as the quick create form controller already executed the 'commitChanges' request in this mutex. Actually, there is no need for the quick create form controller to execute the 'commitChanges' request in the mutex, as it is already properly mutexified upstream. This rev. thus remove the use of the mutex at that spot. Note that before rev. 241704536d3, the bug didn't occur because the 'commitChanges' function of InputField didn't return a deferred, and thus the mutex was unlocked directly. To be complete, let us mention that there are still some concurrency issues with the quick create widget (like multiple records creation on double clicks or double 'ENTER' keypress). Those issues will be tackled in a future commit. Task 1878977
Diffstat (limited to 'addons/web/static/tests/fields/basic_fields_tests.js')
0 files changed, 0 insertions, 0 deletions