summaryrefslogtreecommitdiff
path: root/addons/web/static/tests/fields/basic_fields_tests.js
diff options
context:
space:
mode:
authorSébastien Theys <seb@odoo.com>2019-10-15 14:11:31 +0000
committerfw-bot <otis@odoo.com>2019-10-21 09:08:10 +0000
commit20ac5338ac6bebfce4721f8bc2c9b7d5226bd779 (patch)
tree1d74dd8d323e41a2d1a0cdbfa29d072420d93b03 /addons/web/static/tests/fields/basic_fields_tests.js
parent38133ce0d1e71d1108aaea73323f2921b4876d45 (diff)
[FIX] fields: verify image resolution on create/write
Before this commit, if `max_width` and `max_height` are 0, the image would not be opened by Pillow at all (to gain a bit of CPU) however this was actually a bad idea in this case because then we don't ensure the given value is actually a valid image when we save it, only later at display we notice it and it crashes. This optimization only made sense when `image_process` is called many times, from the route displaying images every time a visitor is requesting an image, for example. It doesn't really have an impact for one time operations such as creating/writing. So when size parameters are 0, which is the default, another parameter must be passed to `image_process` to ensure image validity, and `verify_resolution` is actually built for this, as it does the minimal amount of processing: - loading the image - making sure it is valid - and ensuring the resolution is not completely crazy (`IMAGE_MAX_RESOLUTION`). It doesn't alter the original image if no other operation was requested. Pr: #38292 X-original-commit: e16c36bb4bfa3ae1739712c69c72849665a057dd
Diffstat (limited to 'addons/web/static/tests/fields/basic_fields_tests.js')
0 files changed, 0 insertions, 0 deletions