diff options
| author | Joseph Caburnay <jcb@odoo.com> | 2020-03-06 08:11:36 +0000 |
|---|---|---|
| committer | Joseph Caburnay <jcb@odoo.com> | 2020-03-06 09:04:20 +0000 |
| commit | d6b854306cae245343a7acb9edc4178d245a49fe (patch) | |
| tree | c339d3778c291cea01339f36d9db1c1ad7ed4a43 /addons/web/static/tests/core/util_tests.js | |
| parent | ed1a39c61826d740e2f34f2d2d9072603021503b (diff) | |
[IMP] web: allow patching getters
Previous implementation of patch (web.utils) only allows patching
methods. This commit allows patching getters as well.
closes odoo/odoo#47047
Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
Diffstat (limited to 'addons/web/static/tests/core/util_tests.js')
| -rw-r--r-- | addons/web/static/tests/core/util_tests.js | 80 |
1 files changed, 80 insertions, 0 deletions
diff --git a/addons/web/static/tests/core/util_tests.js b/addons/web/static/tests/core/util_tests.js index 91a9f6b271b..f33a76d87c1 100644 --- a/addons/web/static/tests/core/util_tests.js +++ b/addons/web/static/tests/core/util_tests.js @@ -101,6 +101,86 @@ QUnit.module('core', {}, function () { assert.strictEqual(human_number(-1.012e+43, 2, 2), '-1.01e+43'); }); + QUnit.test('patch a class with getter', function (assert) { + assert.expect(13); + + const { patch } = utils; + + class TestClass { + get val() { + return 'aaa'; + } + } + + const testInstance = new TestClass(); + assert.strictEqual(testInstance.val, 'aaa'); + + // Extend `val` + + const removePatch1 = patch(TestClass, 'patch1', { + get val() { + return this._super + 'bbb'; + }, + }); + assert.strictEqual(testInstance.val, 'aaabbb'); + + const removePatch2 = patch(TestClass, 'patch2', { + get val() { + return this._super + 'ccc'; + }, + }); + assert.strictEqual(testInstance.val, 'aaabbbccc'); + + removePatch1(); + assert.strictEqual(testInstance.val, 'aaaccc'); + + removePatch2(); + assert.strictEqual(testInstance.val, 'aaa'); + + // Add getters + + const removeMorePatch1 = patch(TestClass, 'more-patch-1', { + get realVal() { + return `${this.wrapper.start}${this.val}${this.wrapper.end}` + }, + get wrapper() { + return { + start: '(', + end: ')', + } + } + }) + assert.strictEqual(testInstance.realVal, '(aaa)'); + + const removeMorePatch2 = patch(TestClass, 'more-patch-2', { + get wrapper() { + return { + start: `[${this._super.start}`, + end: `${this._super.end}]`, + } + } + }) + assert.strictEqual(testInstance.realVal, '[(aaa)]'); + + const removeMorePatch3 = patch(TestClass, 'more-patch-3', { + get realVal() { + return `${this._super} - augmented`; + } + }) + assert.strictEqual(testInstance.realVal, '[(aaa)] - augmented'); + + removeMorePatch2(); + assert.strictEqual(testInstance.realVal, '(aaa) - augmented'); + + removeMorePatch3(); + assert.strictEqual(testInstance.realVal, '(aaa)'); + + removeMorePatch1(); + assert.strictEqual(testInstance.realVal, undefined); + assert.strictEqual(testInstance.wrapper, undefined); + assert.strictEqual(testInstance.val, 'aaa'); + }); + }); }); |
