[MERGE][REF] *: update js test suite to use helpers

This rev. introduces robust helpers to use in the JS tests suite to
interact with DOM and components, and starts using them (almost)
everywhere.

All the helpers are exposed though testUtils.js.

There are 2 kinds of helpers:

1. Assertions
-------------
 * assert.containsNone, containsN, containsOnce check that the DOM
   (or a specific part of the DOM) contains a `selector`. It
   generates a correct error message automatically.
    ex: assert.notOk(form.$('button').hasClass('btn-primary'));
       -> assert.doesNotHaveClass(form.$('button'), 'btn-primary');
 * assert.isVisible, isNotVisible check that the DOM has an element
   visible or not. They also check that the element is actually in
   the DOM (before most tests didn't verify this).
 * assert.hasClass, doesNotHaveClass, hasAttrVAlue, check specific
   properties of a DOM element, and also validate that it is
   applied on a single existing DOM element (before most tests
   didn't verify this).

2. Utilities
------------
The goal of the utilities is to centralize the definition of many
standard components and interactions, ensuring that when we
refactor the JS framework, we do not need to change all the tests.

Existing mock utilities (addMockEnvironment, intercept, path,
patchDate, unpatch and fieldsViewGet) are moved to
'testUtils.mock.*'.
Existing DOM utilities are moved to 'testUtils.dom.*'.
New dom utilities are created for opendDatePicker, click,
clickFirst and clickLast. Helper `click` verifies that there is
exactly 1 element visible in the DOM you click on, `clickFirst`
and `clickLast` verify that there are more than one element on the
DOM.
 ex: form.$('button').click();
     -> testUtils.dom.click(form.$('button'));

New Form utilities: (testUtils.form.*)
 clickEdit, clickSave, clickCreate, clickDiscard, all clicks on
 the control panel buttons of the form.
 `reload` reloads the form data.

New modal, graph, kanban and pivot utils (testUtils.pivot.*,
testUtils.kanban.*, etc.).

New fields utils: (testUtils.fields.*)
 * editInput, editSelect: allow to change the value of a field,
   using a selector to identify it. They validate that the input
   exists and trigger the change event automatically.
 * editAndTrigger: allow to modify a field and trigger specific
   events after the value change
 * many2one (testUtils.fields.many2one.*)
   clickOpenDropdown, clickHighlightedItem, clickItem,
   searchAndClickItem: use a field name instead of a selector and
   do all the complex mechanism to open, filter and highlight
   many2one fields.

Joint work with aab, dam, ged, mge, svs and vsc.

closes odoo/odoo#28784

1 files changed, 14 insertions, 27 deletions

diff --git a/addons/web/static/tests/chrome/action_manager_mobile_tests.js b/addons/web/static/tests/chrome/action_manager_mobile_tests.js
index 86738330add..b105c861c26 100644
--- a/addons/web/static/tests/chrome/action_manager_mobile_tests.js
+++ b/addons/web/static/tests/chrome/action_manager_mobile_tests.js
@@ -65,18 +65,14 @@ QUnit.module('ActionManager', {
         // should default on a mobile-friendly view (kanban) for action 1
         actionManager.doAction(1);
 
-        assert.strictEqual(actionManager.$('.o_list_view').length, 0,
-            "should not have rendered the list view");
-        assert.strictEqual(actionManager.$('.o_kanban_view').length, 1,
-            "should have rendered the kanban view");
+        assert.containsNone(actionManager, '.o_list_view');
+        assert.containsOnce(actionManager, '.o_kanban_view');
 
         // there is no mobile-friendly view for action 2, should use the first one (list)
         actionManager.doAction(2);
 
-        assert.strictEqual(actionManager.$('.o_list_view').length, 1,
-            "should have rendered the list view");
-        assert.strictEqual(actionManager.$('.o_kanban_view').length, 0,
-            "there should be no kanban view in the DOM");
+        assert.containsOnce(actionManager, '.o_list_view');
+        assert.containsNone(actionManager, '.o_kanban_view');
 
         actionManager.destroy();
     });
@@ -98,21 +94,15 @@ QUnit.module('ActionManager', {
             view_type: 'form',
         });
 
-        assert.strictEqual(actionManager.$('.o_list_view').length, 0,
-            "should not have rendered a list view");
-        assert.strictEqual(actionManager.$('.o_kanban_view').length, 0,
-            "should not have rendered a kanban view either");
-        assert.strictEqual(actionManager.$('.o_form_view').length, 1,
-            "should have rendered a form view");
+        assert.containsNone(actionManager, '.o_list_view');
+        assert.containsNone(actionManager, '.o_kanban_view');
+        assert.containsOnce(actionManager, '.o_form_view');
 
         // go back to lazy loaded view
-        $('.o_control_panel .breadcrumb a').click();
-        assert.strictEqual(actionManager.$('.o_form_view').length, 0,
-            "should not display the form view anymore");
-        assert.strictEqual(actionManager.$('.o_list_view').length, 0,
-            "should not display the list view either");
-        assert.strictEqual(actionManager.$('.o_kanban_view').length, 1,
-            "should have lazy loaded the kanban view");
+        testUtils.dom.click($('.o_control_panel .breadcrumb .breadcrumb-item:first'));
+        assert.containsNone(actionManager, '.o_form_view');
+        assert.containsNone(actionManager, '.o_list_view');
+        assert.containsOnce(actionManager, '.o_kanban_view');
 
         assert.verifySteps([
             '/web/action/load',
@@ -135,12 +125,9 @@ QUnit.module('ActionManager', {
 
         actionManager.doAction(1);
 
-        assert.ok($('.o_control_panel .o_cp_switch_buttons button[data-toggle="dropdown"]').length, 1,
-            "view switcher button should be displayed");
-        assert.ok($('.o_cp_switch_buttons .o_cp_switch_kanban').hasClass('active'),
-            "kanban should be the active view");
-        assert.ok($('.o_cp_switch_buttons .o_switch_view_button_icon').hasClass('fa-th-large'),
-            "view switcher button icon should be an icon of the kanban");
+        assert.containsOnce($('.o_control_panel'), '.o_cp_switch_buttons button[data-toggle="dropdown"]');
+        assert.hasClass($('.o_cp_switch_buttons .o_cp_switch_kanban'), 'active');
+        assert.hasClass($('.o_cp_switch_buttons .o_switch_view_button_icon'), 'fa-th-large');
 
         actionManager.destroy();
     });