summaryrefslogtreecommitdiff
path: root/addons/web/static/src
diff options
context:
space:
mode:
authorXavier Morel <xmo@odoo.com>2019-02-04 09:17:41 +0000
committerXavier Morel <xmo@odoo.com>2019-02-04 09:17:41 +0000
commitf53ad8a4fd6f1b98625dd659e429177beae7ae80 (patch)
tree0f32e72627debb903c6f47797e7d42f1ffd2b93f /addons/web/static/src
parent9837f250d370428ed73c41e9fb2f68d3a5fa671f (diff)
[FIX] search_filters: broke a thing in f1a85ba
As part of fixing the JS docs (docstrings & references & ...), the various search filters were de-namespaced (aka ExtendedSearchProposition.Integer = ... -> var Integer = ...). This had the side-effect of making a `new Date` refer to the extended search Date field instead of the global Date object, which went unnoticed because *that* had been wrapped in a moment() call, and moment() apparently doesn't mind being given garbage, but it would also create an "unbound" and thus never destroyed widget. Remove the `new Date`, calling moment directly has pretty much the same effect, moment objects created from date objects just have an extra field (a cache for the date object I guess). closes odoo/odoo#30791
Diffstat (limited to 'addons/web/static/src')
-rw-r--r--addons/web/static/src/js/chrome/search_filters.js2
1 files changed, 1 insertions, 1 deletions
diff --git a/addons/web/static/src/js/chrome/search_filters.js b/addons/web/static/src/js/chrome/search_filters.js
index 4628578f9fe..05de554da2f 100644
--- a/addons/web/static/src/js/chrome/search_filters.js
+++ b/addons/web/static/src/js/chrome/search_filters.js
@@ -238,7 +238,7 @@ var DateTime = Field.extend({
_create_new_widget: function (name) {
this[name] = new (this._get_widget_class())(this);
return this[name].appendTo(this.$el).then((function () {
- this[name].setValue(moment(new Date()));
+ this[name].setValue(moment());
}).bind(this));
},
_get_widget_class: function () {