diff options
| author | Mathieu Duckerts-Antoine <dam@odoo.com> | 2019-09-30 08:55:00 +0000 |
|---|---|---|
| committer | Mathieu Duckerts-Antoine <dam@odoo.com> | 2019-10-01 08:32:14 +0000 |
| commit | b919d438c7e0e61816c1f921d1a80af295b3dbef (patch) | |
| tree | cd115f37cbca9a7a8d408e48fdd0dac640bfac47 /addons/web/static/src | |
| parent | 76e941cf84862192777c54a6e489e089f90e3cfe (diff) | |
[FIX] web: repair keyboard navigation in filter menu
Before this commit, invisible filters were rendered by
QWeb but hidden in the filter menu. This used to break
the keyboard navigation in the filter menu.
Now we don't render at all those filters since they were
completely useless anyway. This fixes the original
problem.
Task ID: 2057012
closes odoo/odoo#37567
Signed-off-by: VincentSchippefilt <VincentSchippefilt@users.noreply.github.com>
Diffstat (limited to 'addons/web/static/src')
| -rw-r--r-- | addons/web/static/src/js/views/control_panel/control_panel_model.js | 2 | ||||
| -rw-r--r-- | addons/web/static/src/xml/base.xml | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/addons/web/static/src/js/views/control_panel/control_panel_model.js b/addons/web/static/src/js/views/control_panel/control_panel_model.js index 836a4eceb59..15d2f7487ae 100644 --- a/addons/web/static/src/js/views/control_panel/control_panel_model.js +++ b/addons/web/static/src/js/views/control_panel/control_panel_model.js @@ -234,7 +234,7 @@ var ControlPanelModel = mvc.Model.extend({ if (filter.type === 'field') { filterFields.push(filter); } - if (filter.type === 'filter') { + if (filter.type === 'filter' && !filter.invisible) { filters.push(filter); } if (filter.type === 'groupBy') { diff --git a/addons/web/static/src/xml/base.xml b/addons/web/static/src/xml/base.xml index 02dd25bf0ac..b76e86c036d 100644 --- a/addons/web/static/src/xml/base.xml +++ b/addons/web/static/src/xml/base.xml @@ -1060,8 +1060,8 @@ <t t-if="widget.items.length !== 0"> <t t-set="group" t-value="0"/> <t t-foreach="widget.items" t-as="item"> - <div t-if="group !== item.groupNumber and !item.invisible" role="separator" class="dropdown-divider" data-removable="1"/> - <div t-attf-class="o_menu_item #{item.invisible ? 'd-none' : ''}" + <div t-if="group !== item.groupNumber" role="separator" class="dropdown-divider" data-removable="1"/> + <div t-attf-class="o_menu_item" t-att-data-id="item.id"> <a role="menuitem" href="#" t-attf-class="dropdown-item#{item.isActive ? ' selected ' : ''}"> <t t-esc="item.description"/> |