summaryrefslogtreecommitdiff
path: root/addons/web/static/src
diff options
context:
space:
mode:
authorVidhin Mehta (OpenERP) <vme@tinyerp.com>2011-10-12 17:55:30 +0530
committerVidhin Mehta (OpenERP) <vme@tinyerp.com>2011-10-12 17:55:30 +0530
commit90891fd08f497aae1eb059e492a71e6bd4a043ec (patch)
tree34b8dac283dfbecbe3d9d71f6b0004d043c31782 /addons/web/static/src
parent2f2832f598445cf4266847158208b261fdeb58f4 (diff)
[IMP]if-else replace with switch case
bzr revid: vme@tinyerp.com-20111012122530-prscg6end1y00sh8
Diffstat (limited to 'addons/web/static/src')
-rw-r--r--addons/web/static/src/js/view_editor.js52
1 files changed, 26 insertions, 26 deletions
diff --git a/addons/web/static/src/js/view_editor.js b/addons/web/static/src/js/view_editor.js
index 2881a9a217b..d42470003b6 100644
--- a/addons/web/static/src/js/view_editor.js
+++ b/addons/web/static/src/js/view_editor.js
@@ -198,38 +198,38 @@ openerp.web.ViewEditor = openerp.web.Widget.extend({
if(xpath_object.length!=0){
var check = check_list[0];
var obj;
- if(check.length == 2){
- if(parseInt(check[1])){
- var list_1 = _.select(val,function(element){
+ switch (check.length) {
+ case 2:
+ if(parseInt(check[1])){
+ var list_1 = _.select(val,function(element){
+ var main_list = _.flatten(element.att_list);
+ return _.include(main_list, check[0]);
+ });
+ obj = val[_.indexOf(val,list_1[parseInt(check[1])-1])];
+ } else {
+ obj = _.detect(val, function(element){
+ var main_list = _.flatten(element.att_list);
+ return _.include(main_list, check[0]);
+ });
+ }
+ break;
+ case 3:
+ obj = _.detect(val,function(element){
var main_list = _.flatten(element.att_list);
- return _.include(main_list, check[0]);
+ check = _.uniq(check);
+ var insert = _.intersection(main_list,check);
+ if(insert.length == check.length ){return element;}
});
- obj = val[_.indexOf(val,list_1[parseInt(check[1])-1])];
- } else {
- obj = _.detect(val, function(element){
+ break;
+ case 1:
+ var list_1 = _.select(val,function(element){
var main_list = _.flatten(element.att_list);
return _.include(main_list, check[0]);
});
- }
- }else if(check.length == 3){
- obj = _.detect(val,function(element){
- var main_list = _.flatten(element.att_list);
- check = _.uniq(check);
- var insert = _.intersection(main_list,check);
- if(insert.length == check.length ){return element;}
- });
- }else{
- var list_1 = _.select(val,function(element){
- var main_list = _.flatten(element.att_list);
- return _.include(main_list, check[0]);
- });
- if(list_1 != 0){
- if(check_list.length == 1){
- obj = list_1[0];
- }else{
- check_list.shift();
+ if(list_1 != 0){
+ (check_list.length == 1)? obj = list_1[0] : check_list.shift();
}
- }
+ break;
}
if(obj){
check_list.shift();