diff options
| author | Simon Lejeune <sle@openerp.com> | 2018-08-16 17:24:01 +0200 |
|---|---|---|
| committer | Aaron Bohy <aab@odoo.com> | 2018-08-17 11:24:27 +0200 |
| commit | 3fa2ca07794594d34c4623e4509650b6300bf189 (patch) | |
| tree | 14a01ee6a0944dc5774626594ee44f728b45c731 /addons/web/static/src | |
| parent | 82a46db2deac31d44ab33975791f2a842686d62b (diff) | |
[FIX] web: no_open in field options no longer working
example: <field name="product_id" options="{'no_open': True}" readonly="1"/>
This has been broken by rev. 43d21dd9c due to misplaced parentheses
(an empty object in javascript being truthy).
Diffstat (limited to 'addons/web/static/src')
| -rw-r--r-- | addons/web/static/src/js/fields/relational_fields.js | 2 | ||||
| -rw-r--r-- | addons/web/static/src/xml/base.xml | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/addons/web/static/src/js/fields/relational_fields.js b/addons/web/static/src/js/fields/relational_fields.js index 692d27e0ca8..65ec9f33ddf 100644 --- a/addons/web/static/src/js/fields/relational_fields.js +++ b/addons/web/static/src/js/fields/relational_fields.js @@ -126,7 +126,7 @@ var FieldMany2One = AbstractField.extend({ this.nodeOptions = _.defaults(this.nodeOptions, { quick_create: true, }); - this.noOpen = ('noOpen' in options || {}) ? options.noOpen : this.nodeOptions.no_open; + this.noOpen = 'noOpen' in (options || {}) ? options.noOpen : this.nodeOptions.no_open; this.m2o_value = this._formatValue(this.value); // 'recordParams' is a dict of params used when calling functions // 'getDomain' and 'getContext' on this.record diff --git a/addons/web/static/src/xml/base.xml b/addons/web/static/src/xml/base.xml index 261a45f46f5..3651bd25d4e 100644 --- a/addons/web/static/src/xml/base.xml +++ b/addons/web/static/src/xml/base.xml @@ -818,7 +818,7 @@ t-att-id="widget.idForLabel"/> <a role="button" class="o_dropdown_button" draggable="false"/> </div> - <button type="button" t-if="!widget.nodeOptions.no_open" class="fa fa-external-link btn btn-secondary o_external_button" tabindex="-1" draggable="false" aria-label="External link" title="External link"/> + <button type="button" t-if="!widget.noOpen" class="fa fa-external-link btn btn-secondary o_external_button" tabindex="-1" draggable="false" aria-label="External link" title="External link"/> </div> </t> <t t-name="FieldReference" t-extend="FieldMany2One"> |