[FIX] web: toggle favorite correctly updates other filters status

When toggling a favorite filter, the options used by
the active date filters/groupbys and the field created
via autocompletion were not correctly cleared, leading
to strange situations. This is fixed by this commit.

1 files changed, 11 insertions, 1 deletions

diff --git a/addons/web/static/src/js/views/control_panel/control_panel_model.js b/addons/web/static/src/js/views/control_panel/control_panel_model.js
index 208f3b7ee19..836a4eceb59 100644
--- a/addons/web/static/src/js/views/control_panel/control_panel_model.js
+++ b/addons/web/static/src/js/views/control_panel/control_panel_model.js
@@ -409,7 +409,17 @@ var ControlPanelModel = mvc.Model.extend({
             // we need to deactivate all groups when activating a favorite
             if (filter.type === 'favorite') {
                 this.query.forEach(function (groupId) {
-                    self.groups[groupId].activeFilterIds = [];
+                    const group = self.groups[groupId];
+                    group.activeFilterIds.forEach(id => {
+                        const filter = self.filters[id[0]];
+                        if (filter.autoCompleteValues) {
+                            filter.autoCompleteValues = [];
+                        }
+                        if (filter.currentOptionIds) {
+                            filter.currentOptionIds.clear();
+                        }   
+                    })
+                    group.activeFilterIds = [];
                 });
                 this.query = [];
             }