diff options
| author | Luis González <lgonzalez@vauxoo.com> | 2020-03-21 23:43:29 +0000 |
|---|---|---|
| committer | Nicolas Lempereur <nle@odoo.com> | 2020-03-25 12:39:02 +0000 |
| commit | 5dda9a709eb93af7de5b184cb823b0ebeaad2db1 (patch) | |
| tree | 99fd4d7dc2850e03b7bbad68f433d85b22fb27d0 /addons/web/static/src/xml/base.xml | |
| parent | 52a98f74f309338181fe8e4491905aaaec085bbe (diff) | |
[FIX] web,mail: Harmful or incomplete aria-label attributes
Some elements contain superfluous `aria-label` attributes, which
overrides any default useful information. For instance, some dropdown
menus contain the `aria-label` "Dropdown menu" (e.g. the company
switcher), which doesn't add any useful information, as dropdown menus
are already labelled correctly using `aria-expanded`.
This change applies on the following buttons:
- Schedule an activity
- View attachments
- View followers
- Switch company
- Open user options from systray
- The widget `state_selection`
closes odoo/odoo#48317
X-original-commit: e3c7f66e89d7be39dfa4cc3d6b038c6f4a114aa5
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
Diffstat (limited to 'addons/web/static/src/xml/base.xml')
| -rw-r--r-- | addons/web/static/src/xml/base.xml | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/addons/web/static/src/xml/base.xml b/addons/web/static/src/xml/base.xml index 9e799e44e38..392025436f5 100644 --- a/addons/web/static/src/xml/base.xml +++ b/addons/web/static/src/xml/base.xml @@ -1041,7 +1041,7 @@ <t t-name="FormSelection"> <div class="btn-group o_selection" aria-atomic="true"> - <a href="#" data-toggle="dropdown" aria-label="Dropdown menu" title="Dropdown menu"><span class="o_status"/></a> + <a href="#" data-toggle="dropdown" aria-expanded="false" role="button" title="Dropdown menu"><span class="o_status"/></a> <div class="dropdown-menu state" role="menu"/> </div> </t> @@ -1725,7 +1725,7 @@ <t t-name="UserMenu"> <li class="o_user_menu"> <a role="button" class="dropdown-toggle o-no-caret" data-toggle="dropdown" data-display="static" aria-expanded="false" href="#"> - <img class="rounded-circle oe_topbar_avatar" t-att-src="_s + '/web/static/src/img/user_menu_avatar.png'" alt="Avatar"/> + <img class="rounded-circle oe_topbar_avatar" t-att-src="_s + '/web/static/src/img/user_menu_avatar.png'" alt="User"/> <span class="oe_topbar_name"/> </a> <div class="dropdown-menu dropdown-menu-right" role="menu"> @@ -1745,7 +1745,7 @@ <t t-name="SwitchCompanyMenu"> <li class="o_switch_company_menu"> - <a role="button" class="dropdown-toggle o-no-caret" data-toggle="dropdown" data-display="static" aria-expanded="false" href="#" aria-label="Dropdown menu" title="Dropdown menu"> + <a role="button" class="dropdown-toggle o-no-caret" data-toggle="dropdown" data-display="static" aria-expanded="false" href="#" title="Dropdown menu"> <span t-attf-class="#{widget.isMobile ? 'fa fa-building-o' : 'oe_topbar_name'}"> <t t-if="!widget.isMobile"><t t-raw="widget.current_company_name"/></t> </span> |
