[FIX] web: do not create new line if onchange has warning in o2m

In a one2many field, when the user clicks on the 'Add a line' button, we
need to create a new record.  This means that we call the default_get
route, then call the onchanges.  The onchange can return a 'warning'
key, which is displayed to the user.  But in the specific case of a
one2many, we don't want to actually create the record.  So, we reject the
deferred to prevent that from happening.

1 files changed, 7 insertions, 1 deletions

diff --git a/addons/web/static/src/js/views/basic/basic_model.js b/addons/web/static/src/js/views/basic/basic_model.js
index f93635618e3..9139906f982 100644
--- a/addons/web/static/src/js/views/basic/basic_model.js
+++ b/addons/web/static/src/js/views/basic/basic_model.js
@@ -770,6 +770,7 @@ var BasicModel = AbstractModel.extend({
             var onchangeDef;
             if (onChangeFields.length) {
                 onchangeDef = self._applyOnChange(record, onChangeFields).then(function (result) {
+                    delete record._warning;
                     return _.keys(changes).concat(Object.keys(result && result.value || {}));
                 });
             } else {
@@ -884,6 +885,7 @@ var BasicModel = AbstractModel.extend({
                         title: result.warning.title,
                         type: 'dialog',
                     });
+                    record._warning = true;
                 }
                 var defs = [];
                 _.each(result.value, function (val, name) {
@@ -2045,7 +2047,11 @@ var BasicModel = AbstractModel.extend({
                             }
                         }
                         if (shouldApplyOnchange) {
-                            return self._applyOnChange(record, fields_key);
+                            return self._applyOnChange(record, fields_key).then(function () {
+                                if (record._warning) {
+                                    return $.Deferred().reject();
+                                }
+                            });
                         } else {
                             return $.when();
                         }