diff options
| author | Aaron Bohy <aab@odoo.com> | 2018-04-12 10:58:45 +0200 |
|---|---|---|
| committer | Aaron Bohy <aab@odoo.com> | 2018-04-13 12:09:01 +0200 |
| commit | b096915dc8e8c2b4547b19db177c3b614ca98620 (patch) | |
| tree | 3e9db465a2bb46ad61245cf68879f2a4057cb42d /addons/web/static/src/js/widgets/debug_manager.js | |
| parent | 1d92bb410db693e2e670006ec6eb003be72f24f4 (diff) | |
[FIX] board: stop the propagation of custom events
Recently, rev. 5b3cb812b added a new custom event ('update_filters')
handler to the ActionManager, and rev. 69c9500 added an option
('keepSearchView') to doAction (which can be called by triggering
up event 'do_action').
Both events ('update_filters' and 'do_action') can be triggered by
controllers, and when those controllers were in the dashboard, a
crash occured when they triggered those events. In particular, they
are triggered by the new 'web_dashboard' view, respectively when
clicking on an aggregate and when clicking on the subview button to
open it full screen.
The crashes occurred because the events weren't intercepted by the
dashboard, so they bubbled up to the ActionManager which couldn't
handle the requests properly as it wasn't aware of those sub
controllers.
As there is no search view in the dashboard, the 'update_filters'
event simply needs to be stopped (we can't handle such a request
in the dashboard), and for the 'do_action' event, the
'keepSearchView' option must be forced to false as there is no
search view to keep (we thus force the ActionManager to create a
new one).
Diffstat (limited to 'addons/web/static/src/js/widgets/debug_manager.js')
0 files changed, 0 insertions, 0 deletions
