diff options
| author | Sébastien Theys <seb@odoo.com> | 2018-07-10 13:52:18 +0200 |
|---|---|---|
| committer | Sébastien Theys <seb@odoo.com> | 2018-07-17 11:50:35 +0200 |
| commit | d1f1cc9c275de726de3cd2491c8d8b4866bbeb0e (patch) | |
| tree | 6916b6dd42b5bee05a100a8a213cb69b2931b47b /addons/web/static/src/js/views | |
| parent | 561d22feb7f3d3b77978e147aca421da3d9bcc2d (diff) | |
[FIX] web: prevent tab shortcut from crashing when no input field
Currently, using the shortcut "tab" inside a list will crash if the list has no input field (ex. if it has only a textarea field).
This commit prevents the bug.
Also moved the test for the orderedResIDs crash in the correct module.
PR #25209
Diffstat (limited to 'addons/web/static/src/js/views')
| -rw-r--r-- | addons/web/static/src/js/views/list/list_editable_renderer.js | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/addons/web/static/src/js/views/list/list_editable_renderer.js b/addons/web/static/src/js/views/list/list_editable_renderer.js index bf54ad19f22..382df0b9444 100644 --- a/addons/web/static/src/js/views/list/list_editable_renderer.js +++ b/addons/web/static/src/js/views/list/list_editable_renderer.js @@ -768,10 +768,13 @@ ListRenderer.include({ var record = this.state.data[this.currentRow]; var recordWidgets = this.allFieldWidgets[record.id]; var firstWidget = _.find(recordWidgets, function (widget) { - var isFirst = widget.$el.is(':visible') && - (widget.$el.has('input').length > 0 || - widget.tagName== 'input') && - !widget.$el.hasClass('o_readonly_modifier'); + var isFirst = + widget.$el.is(':visible') && + ( + widget.$('input').length > 0 || widget.tagName === 'input' || + widget.$('textarea').length > 0 || widget.tagName === 'textarea' + ) && + !widget.$el.hasClass('o_readonly_modifier'); return isFirst; }); return firstWidget; |
