diff options
| author | Luis González <lgonzalez@vauxoo.com> | 2021-03-13 18:11:00 +0000 |
|---|---|---|
| committer | Nicolas Lempereur <nle@odoo.com> | 2021-05-05 12:25:12 +0000 |
| commit | ac3e0fcd32d66d6e0bacfabd2d224805d92dbfd1 (patch) | |
| tree | 76c2e3023ba18331595c2d34ae2a0b64a140d3d8 /addons/web/static/src/js/views | |
| parent | 51b2c7fad08354499503c5c444dd1a3ae1f26fc1 (diff) | |
[FIX] web: Aria attributes on buttons Export All & optional columns
Some aria attributes were missing or incorrectly set on these new
buttons:
- The button "Export All" was missing an `aria-label` attribute
- The button to show/hide optional columns was also missing an
`aria-label` attribute, and its menu items (checkboxes to show/hide
columns) were missing a proper role
- Ever since the debug manager was added in frontend on 73327db0656b,
the `aria-label` attribute was not being rendered correctly on the
button to open developer tools
closes odoo/odoo#70390
X-original-commit: 620e4cc28cefed6f4a3b5ca89b11cc37222acfaf
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
Diffstat (limited to 'addons/web/static/src/js/views')
| -rw-r--r-- | addons/web/static/src/js/views/list/list_renderer.js | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/addons/web/static/src/js/views/list/list_renderer.js b/addons/web/static/src/js/views/list/list_renderer.js index cda4e07e5b4..93fb8ea68d2 100644 --- a/addons/web/static/src/js/views/list/list_renderer.js +++ b/addons/web/static/src/js/views/list/list_renderer.js @@ -983,6 +983,7 @@ var ListRenderer = BasicRenderer.extend({ 'data-toggle': "dropdown", 'data-display': "static", 'aria-expanded': false, + 'aria-label': _t('Optional columns'), }); $a.appendTo($optionalColumnsDropdown); @@ -1001,6 +1002,7 @@ var ListRenderer = BasicRenderer.extend({ (config.isDebug() ? (' (' + col.attrs.name + ')') : ''); var $checkbox = dom.renderCheckbox({ text: txt, + role: "menuitemcheckbox", prop: { name: col.attrs.name, checked: _.contains(self.optionalColumnsEnabled, col.attrs.name), |
