summaryrefslogtreecommitdiff
path: root/addons/web/static/src/js/views
diff options
context:
space:
mode:
authorAdrien Dieudonne <adr@odoo.com>2018-07-06 14:22:58 +0200
committerAdrien Dieudonne <adr@odoo.com>2018-07-06 14:22:58 +0200
commit3ebff1f4721dd4a9057db4d26162c57c8506700a (patch)
treee3b02fcc528dcc3a0ae50b55a5d3a1d4708ab992 /addons/web/static/src/js/views
parentf9a68d5e778da0ff4e1f1a0936b51b98a822a15a (diff)
parent11b7857af63a35e81daa495bcb3522b3915f32ca (diff)
[MERGE] *: Easy date filters
This commit allow to create easily a range of periods (related to a field of date or datetime type) to select in the filters menu. Two new attributes on elements with tag 'filter' are now usable in combination in a search view arch: - date: string. A valid field name with associated type date or datetime - default_period: string (optional). To choose in the following list: - 'today' - 'this_week' - 'this_month' (default) - 'this_quarter' - 'this_year' - 'yesterday' - 'last_week' - 'last_month' - 'last_quarter' - 'last_year' - 'last_7_days' - 'last_30_days' - 'last_365_days' Example: <filter string="Creation Date" name="period_generator" date="create_date" default_period="this_quarter"/> Note: the attribute 'domain' can not be used for such filters. The generated domains are dynamic and can be saved as such via the favorites menu. task-10532
Diffstat (limited to 'addons/web/static/src/js/views')
-rw-r--r--addons/web/static/src/js/views/basic/basic_view.js6
-rw-r--r--addons/web/static/src/js/views/list/list_controller.js4
-rw-r--r--addons/web/static/src/js/views/search/favorites_menu.js25
-rw-r--r--addons/web/static/src/js/views/search/filters_menu.js86
-rw-r--r--addons/web/static/src/js/views/search/groupby_menu.js24
-rw-r--r--addons/web/static/src/js/views/search/search_inputs.js65
-rw-r--r--addons/web/static/src/js/views/search/search_view.js264
-rw-r--r--addons/web/static/src/js/views/view_dialogs.js6
8 files changed, 341 insertions, 139 deletions
diff --git a/addons/web/static/src/js/views/basic/basic_view.js b/addons/web/static/src/js/views/basic/basic_view.js
index 2c4ed711223..7bc5e95bfc8 100644
--- a/addons/web/static/src/js/views/basic/basic_view.js
+++ b/addons/web/static/src/js/views/basic/basic_view.js
@@ -15,7 +15,7 @@ var BasicController = require('web.BasicController');
var BasicModel = require('web.BasicModel');
var config = require('web.config');
var fieldRegistry = require('web.field_registry');
-var pyeval = require('web.pyeval');
+var pyUtils = require('web.py_utils');
var utils = require('web.utils');
var BasicView = AbstractView.extend({
@@ -216,13 +216,13 @@ var BasicView = AbstractView.extend({
attrs.decorations = attrs.decorations || [];
attrs.decorations.push({
className: 'text-' + splitKey[1],
- expression: py.parse(py.tokenize(value))
+ expression: pyUtils._getPyJSAST(value),
});
}
});
if (!_.isObject(attrs.options)) { // parent arch could have already been processed (TODO this should not happen)
- attrs.options = attrs.options ? pyeval.py_eval(attrs.options) : {};
+ attrs.options = attrs.options ? pyUtils.py_eval(attrs.options) : {};
}
if (attrs.on_change && !field.onChange) {
diff --git a/addons/web/static/src/js/views/list/list_controller.js b/addons/web/static/src/js/views/list/list_controller.js
index ae1a8f7305b..a210c07a885 100644
--- a/addons/web/static/src/js/views/list/list_controller.js
+++ b/addons/web/static/src/js/views/list/list_controller.js
@@ -11,7 +11,7 @@ var core = require('web.core');
var BasicController = require('web.BasicController');
var DataExport = require('web.DataExport');
var Dialog = require('web.Dialog');
-var pyeval = require('web.pyeval');
+var pyUtils = require('web.py_utils');
var Sidebar = require('web.Sidebar');
var _t = core._t;
@@ -67,7 +67,7 @@ var ListController = BasicController.extend({
if (this.$('thead .o_list_record_selector input').prop('checked')) {
var searchData = this.searchView.build_search_data();
var userContext = this.getSession().user_context;
- var results = pyeval.eval_domains_and_contexts({
+ var results = pyUtils.eval_domains_and_contexts({
domains: searchData.domains,
contexts: [userContext].concat(searchData.contexts),
group_by_seq: searchData.groupbys || []
diff --git a/addons/web/static/src/js/views/search/favorites_menu.js b/addons/web/static/src/js/views/search/favorites_menu.js
index f0962e6177e..1e62ffb5ce3 100644
--- a/addons/web/static/src/js/views/search/favorites_menu.js
+++ b/addons/web/static/src/js/views/search/favorites_menu.js
@@ -4,7 +4,8 @@ odoo.define('web.FavoriteMenu', function (require) {
var config = require('web.config');
var core = require('web.core');
var data_manager = require('web.data_manager');
-var pyeval = require('web.pyeval');
+var Domain = require('web.Domain');
+var pyUtils = require('web.py_utils');
var session = require('web.session');
var Widget = require('web.Widget');
@@ -98,15 +99,17 @@ return Widget.extend({
return;
}
var user_context = this.getSession().user_context;
- var search = this.searchview.build_search_data();
+ // get search params with domains not evaluated
+ var search = this.searchview.build_search_data(true);
+ var domain = pyUtils.assembleDomains(search.domains, 'AND');
var controllerContext;
this.trigger_up('get_controller_context', {
callback: function (ctx) {
controllerContext = ctx;
},
});
- var results = pyeval.eval_domains_and_contexts({
- domains: search.domains,
+ var results = pyUtils.eval_domains_and_contexts({
+ domains: [],
contexts: [user_context].concat(search.contexts.concat(controllerContext || [])),
group_by_seq: search.groupbys || [],
});
@@ -125,7 +128,7 @@ return Widget.extend({
user_id: shared_filter ? false : session.uid,
model_id: this.target_model,
context: results.context,
- domain: results.domain,
+ domain: domain,
sort: JSON.stringify(this.searchview.dataset._sort),
is_default: default_filter,
action_id: this.action_id,
@@ -180,13 +183,23 @@ return Widget.extend({
* @return {Object}
*/
facet_for: function (filter) {
+ var self = this;
return {
category: _t("Custom Filter"),
icon: 'fa-star',
field: {
get_context: function () { return filter.context; },
get_groupby: function () { return [filter.context]; },
- get_domain: function () { return filter.domain; }
+ // facet is not used
+ get_domain: function (facet, noEvaluation) {
+ noEvaluation = noEvaluation || false;
+ var userContext = self.getSession().user_context;
+ var domain = pyUtils.assembleDomains([filter.domain]);
+ if (!noEvaluation) {
+ return Domain.prototype.stringToArray(domain, userContext);
+ }
+ return domain;
+ }
},
_id: filter.id,
is_custom_filter: true,
diff --git a/addons/web/static/src/js/views/search/filters_menu.js b/addons/web/static/src/js/views/search/filters_menu.js
index 778e199df44..221f98faa97 100644
--- a/addons/web/static/src/js/views/search/filters_menu.js
+++ b/addons/web/static/src/js/views/search/filters_menu.js
@@ -3,14 +3,15 @@ odoo.define('web.FiltersMenu', function (require) {
var config = require('web.config');
var core = require('web.core');
+var Domain = require('web.Domain');
var DropdownMenu = require('web.DropdownMenu');
var search_filters = require('web.search_filters');
+var time = require('web.time');
var QWeb = core.qweb;
var _t = core._t;
-
var FiltersMenu = DropdownMenu.extend({
custom_events: {
remove_proposition: '_onRemoveProposition',
@@ -20,6 +21,7 @@ var FiltersMenu = DropdownMenu.extend({
'click .o_add_custom_filter': '_onAddCustomFilterClick',
'click .o_add_condition': '_appendProposition',
'click .o_apply_filter': '_onApplyClick',
+ ':hover .o_item_option': '_onOptionHover',
}),
/**
@@ -29,6 +31,8 @@ var FiltersMenu = DropdownMenu.extend({
* interface IFilter {
* itemId: string; unique id associated with the filter
* domain: string;
+ * isPeriod: boolean
+ * fieldName: string; fieldName used to generate a domain in case isDate is true (and domain empty)
* description: string; label printed on screen
* groupId: string;
* isActive: boolean; (optional) determines if the filter is considered active
@@ -46,16 +50,21 @@ var FiltersMenu = DropdownMenu.extend({
// determines where the filter menu is displayed and its style
this.isMobile = config.device.isMobile;
// determines list of options used by filter of type 'date'
- // TO DO: simplify optionIds below
- this.intervalOptions = [
- {description: _t('Day'), optionId: '__interval__day__'},
- {description: _t('Week'), optionId: '__interval__week__'},
- {description: _t('Month'), optionId: '__interval__month__'},
- {description: _t('Year'), optionId: '__interval__year__'},
+ this.periodOptions = [
+ {description: _t('Today'), optionId: 'today', groupId: 1},
+ {description: _t('This Week'), optionId: 'this_week', groupId: 1},
+ {description: _t('This Month'), optionId: 'this_month', groupId: 1},
+ {description: _t('This Quarter'), optionId: 'this_quarter', groupId: 1},
+ {description: _t('This Year'), optionId: 'this_year', groupId: 1},
+ {description: _t('Yesterday'), optionId: 'yesterday', groupId: 2},
+ {description: _t('Last Week'), optionId: 'last_week', groupId: 2},
+ {description: _t('Last Month'), optionId: 'last_month', groupId: 2},
+ {description: _t('Last Quarter'), optionId: 'last_quarter', groupId: 2},
+ {description: _t('Last Year'), optionId: 'last_year', groupId: 2},
+ {description: _t('Last 7 Days'), optionId: 'last_7_days', groupId: 3},
+ {description: _t('Last 30 Days'), optionId: 'last_30_days', groupId: 3},
+ {description: _t('Last 365 Days'), optionId: 'last_365_days', groupId: 3},
];
- // determines the default option used in case
- // it has not been provided for a filter
- this.defaultOptionId = "__interval__month__";
// determines when the 'Add custom filter' submenu is open
this.generatorMenuIsOpen = false;
this.propositions = [];
@@ -111,8 +120,11 @@ var FiltersMenu = DropdownMenu.extend({
_commitSearch: function () {
var self = this;
var filters = _.invoke(this.propositions, 'get_filter');
+ _.each(filters, function (filter) {
+ filter.attrs.domain = Domain.prototype.arrayToString(filter.attrs.domain);
+ });
var groupId = _.uniqueId('__group__');
- var toSendToSearchView = [];
+ var data = [];
filters.forEach(function (filter) {
var filterName = _.uniqueId('__filter__');
var filterItem = {
@@ -122,7 +134,7 @@ var FiltersMenu = DropdownMenu.extend({
isActive: true,
};
self._prepareItem(filterItem);
- toSendToSearchView.push({
+ data.push({
itemId: filterName,
groupId: groupId,
filter: filter,
@@ -130,13 +142,59 @@ var FiltersMenu = DropdownMenu.extend({
self.items.push(filterItem);
});
this._renderMenuItems();
- this.trigger_up('new_filter', toSendToSearchView);
+ this.trigger_up('new_filters', data);
_.invoke(this.propositions, 'destroy');
this.propositions = [];
- // this._appendProposition();
this._toggleCustomFilterMenu();
},
/**
+ * override
+ *
+ * @private
+ * @param {Object} item
+ */
+ _prepareItem: function (item) {
+ if (item.isPeriod) {
+ item.options = this.periodOptions;
+ }
+ // super has to be called here because we need to add options to groupby
+ // before to call it since some keys in a groupby are initialized using
+ // the keys 'options' and 'defaultOptionId'
+ this._super.apply(this, arguments);
+ },
+ /**
+ * override
+ *
+ * @private
+ */
+ _renderMenuItems: function () {
+ var self= this;
+ this._super.apply(this, arguments);
+ // the following code adds tooltip on date options in order
+ // to alert the user of the meaning of intervals
+ var $options = this.$('ul.o_dropdown_menu .o_item_option');
+ $options.each(function () {
+ var $option = $(this);
+ $option.tooltip({
+ delay: { show: 500, hide: 0 },
+ title: function () {
+ var itemId = $option.attr('data-item_id');
+ var optionId = $option.attr('data-option_id');
+ var fieldName = _.findWhere(self.items, {itemId: itemId}).fieldName;
+ var domain = Domain.prototype.constructDomain(fieldName, optionId, 'date', true);
+ var evaluatedDomain = Domain.prototype.stringToArray(domain);
+ var dateFormat = time.getLangDateFormat();
+ var dateStart = moment(evaluatedDomain[1][2], "YYYY-MM-DD", 'en').format(dateFormat);
+ var dateEnd = moment(evaluatedDomain[2][2], "YYYY-MM-DD", 'en').format(dateFormat);
+ if (optionId === 'today' || optionId === 'yesterday') {
+ return dateStart;
+ }
+ return _.str.sprintf(_t('From %s To %s'), dateStart, dateEnd);
+ }
+ });
+ });
+ },
+ /**
* Hide and display the sub menu which allows adding custom filters
*
* @private
diff --git a/addons/web/static/src/js/views/search/groupby_menu.js b/addons/web/static/src/js/views/search/groupby_menu.js
index 4e3c4eb573d..f32cf314a33 100644
--- a/addons/web/static/src/js/views/search/groupby_menu.js
+++ b/addons/web/static/src/js/views/search/groupby_menu.js
@@ -9,6 +9,8 @@ var QWeb = core.qweb;
var GROUPABLE_TYPES = ['many2one', 'char', 'boolean', 'selection', 'date', 'datetime'];
+var DEFAULT_INTERVAL = 'month';
+
var GroupByMenu = DropdownMenu.extend({
events: _.extend({}, DropdownMenu.prototype.events,
{
@@ -26,12 +28,12 @@ var GroupByMenu = DropdownMenu.extend({
* fieldName: string; field name without interval!
* description: string; label printed on screen
* groupId: string;
+ * isDate: boolean;
* isActive: boolean; (optional) determines if the groupby is considered active
* isOpen: boolean; (optional) in case there are options the submenu presenting the options
* is opened or closed according to isOpen
* isRemovable: boolean; (optional) can be removed from menu
* options: array of objects with 'optionId' and 'description' keys; (optional)
- * defaultOptionId: string refers to an optionId (optional)
* currentOptionId: string refers to an optionId that is activated if item is active (optional)
* }
* @param {Object} fields 'field_get' of a model: mapping from field name
@@ -46,15 +48,12 @@ var GroupByMenu = DropdownMenu.extend({
this.generatorMenuIsOpen = false;
// determines list of options used by groupbys of type 'date'
this.intervalOptions = [
- {description: 'Day', optionId: 'day'},
- {description: 'Week', optionId: 'week'},
- {description: 'Month', optionId: 'month'},
- {description: 'Quarter', optionId: 'quarter'},
- {description: 'Year', optionId: 'year'},
+ {description: 'Day', optionId: 'day', groupId: 1},
+ {description: 'Week', optionId: 'week', groupId: 1},
+ {description: 'Month', optionId: 'month', groupId: 1},
+ {description: 'Quarter', optionId: 'quarter', groupId: 1},
+ {description: 'Year', optionId: 'year', groupId: 1},
];
- // determines the default option used in case
- // it has not been provided for a groupby
- this.defaultOptionId = "month";
this.groupableFields = [];
_.each(fields, function (field, name) {
if (field.sortable && _.contains(GROUPABLE_TYPES, field.type)) {
@@ -114,7 +113,7 @@ var GroupByMenu = DropdownMenu.extend({
* method called via the 'Add Custom Groupby' menu to create
* a new groupby and add it (activated) to the menu
* In case the field is of type date, it is activated using
- * the option determined by the parameter 'this.defaultOptionId'
+ * the option determined by the parameter 'DEFAULT_INTERVAL'
*
* @private
* @param {string} fieldName
@@ -132,8 +131,10 @@ var GroupByMenu = DropdownMenu.extend({
var eventData = _.clone(groupby);
this._prepareItem(groupby);
if (groupby.hasOptions) {
- groupby.currentOptionId = groupby.defaultOptionId;
+ groupby.currentOptionId = DEFAULT_INTERVAL;
+ groupby.isDate = true;
eventData.optionId = groupby.currentOptionId;
+ eventData.isDate = true;
}
this.items.push(groupby);
var fieldIndex = this.presentedFields.indexOf(field);
@@ -151,7 +152,6 @@ var GroupByMenu = DropdownMenu.extend({
_prepareItem: function (item) {
if (_.contains(['date', 'datetime'], this.fields[item.fieldName].type)) {
item.options = this.intervalOptions;
- item.defaultOptionId = item.defaultOptionId || this.defaultOptionId;
}
// the idea is that we have only one group in the groupby menu
// like in the search view.
diff --git a/addons/web/static/src/js/views/search/search_inputs.js b/addons/web/static/src/js/views/search/search_inputs.js
index 3366fe91ecb..ee179d7da74 100644
--- a/addons/web/static/src/js/views/search/search_inputs.js
+++ b/addons/web/static/src/js/views/search/search_inputs.js
@@ -5,7 +5,7 @@ var Context = require('web.Context');
var core = require('web.core');
var Domain = require('web.Domain');
var field_utils = require('web.field_utils');
-var pyeval = require('web.pyeval');
+var pyUtils = require('web.py_utils');
var time = require('web.time');
var utils = require('web.utils');
var Widget = require('web.Widget');
@@ -416,7 +416,7 @@ var ManyToOneField = CharField.extend({
expand: function (needle) {
var self = this;
// FIXME: "concurrent" searches (multiple requests, mis-ordered responses)
- var context = pyeval.eval(
+ var context = pyUtils.eval(
'contexts', [this.searchview.dataset.get_context()]);
var args = this.attrs.domain;
if (typeof args === 'string') {
@@ -458,7 +458,7 @@ var ManyToOneField = CharField.extend({
// to handle this as if it were a single value.
value = value[0];
}
- var context = pyeval.eval('contexts', [this.searchview.dataset.get_context()]);
+ var context = pyUtils.eval('contexts', [this.searchview.dataset.get_context()]);
return this._rpc({
model: this.attrs.relation,
@@ -514,14 +514,17 @@ var FilterGroup = Input.extend(/** @lends instance.web.search.FilterGroup# */{
*
* @param {Array<instance.web.search.Filter>} filters elements of the group
* @param {instance.web.SearchView} parent parent in which the filters are contained
+ * @param {Object} intervalMapping, a key is a field name and the corresponding value
+ * is the current interval used
+ * (necessarily the field is of type 'date' or 'datetime')
*/
- init: function (filters, parent, intervalMapping) {
+ init: function (filters, parent, intervalMapping, periodMapping) {
// If all filters are group_by and we're not initializing a GroupbyGroup,
// create a GroupbyGroup instead of the current FilterGroup
if (!(this instanceof GroupbyGroup) &&
_(filters).all(function (f) {
if (!f.attrs.context) { return false; }
- var c = pyeval.eval('context', f.attrs.context);
+ var c = pyUtils.eval('context', f.attrs.context);
return !_.isEmpty(c.group_by);})) {
return new GroupbyGroup(filters, parent, intervalMapping);
}
@@ -529,6 +532,7 @@ var FilterGroup = Input.extend(/** @lends instance.web.search.FilterGroup# */{
this.filters = filters;
this.searchview = parent;
this.intervalMapping = intervalMapping;
+ this.periodMapping = periodMapping || [];
this.searchview.query.on('add remove change reset', this.proxy('search_change'));
},
start: function () {
@@ -637,29 +641,45 @@ var FilterGroup = Input.extend(/** @lends instance.web.search.FilterGroup# */{
* Handles domains-fetching for all the filters within it: groups them.
*
* @param {VS.model.SearchFacet} facet
+ * @param {boolean} noEvaluation determines if the domains are evaluated or not.
+ By default, domains are evaluated.
* @return {*} combined domains of the enabled filters in this group
*/
- get_domain: function (facet) {
+ get_domain: function (facet, noEvaluation) {
+ noEvaluation = noEvaluation || false;
+ var self = this;
var userContext = this.getSession().user_context;
var domains = facet.values.chain()
- .map(function (f) { return f.get('value').attrs.domain; })
+ .map(function (f) {
+ var filter = f.get('value');
+ var attributes = filter.attrs;
+ var domain = attributes.domain;
+ var fieldName = attributes.date;
+ if (!domain && fieldName) {
+ var couple = _.findWhere(self.periodMapping, {filter: filter});
+ var period = couple ? couple.period: 'this_month';
+ var type = couple ? couple.type: 'date';
+ domain = Domain.prototype.constructDomain(fieldName, period, type);
+ }
+ return domain;
+ })
.without('[]')
.reject(_.isEmpty)
- .map(function (d) {
- return Domain.prototype.stringToArray(d, userContext);
+ .map(function (domain) {
+ domain = domain.replace(/%%/g, '%');
+ return domain;
})
.value();
if (!domains.length) {
return;
}
- if (domains.length === 1) {
- return domains[0];
+ // domains belong the same groups. We need to make a union.
+ var domain = pyUtils.assembleDomains(domains, 'OR');
+ if (!noEvaluation) {
+ return Domain.prototype.stringToArray(domain, userContext);
}
-
- _.each(domains, Domain.prototype.normalizeArray);
- var ors = _.times(domains.length - 1, _.constant("|"));
- return ors.concat.apply(ors, domains);
+ return domain;
},
toggle_filter: function (e) {
e.preventDefault();
@@ -701,9 +721,22 @@ var FilterGroup = Input.extend(/** @lends instance.web.search.FilterGroup# */{
};
}));
},
+ /*
+ * @param {Object} intervalMapping
+ */
updateIntervalMapping: function (intervalMapping) {
this.intervalMapping = intervalMapping;
- }
+ },
+ /*
+ * @param {Object} periodMapping
+ */
+ updatePeriodMapping: function (periodMapping) {
+ this.intervalMapping = periodMapping;
+ },
+
+ //--------------------------------------------------------------------------
+ // Private
+ //--------------------------------------------------------------------------
});
diff --git a/addons/web/static/src/js/views/search/search_view.js b/addons/web/static/src/js/views/search/search_view.js
index e307ca2a240..91075bc4972 100644
--- a/addons/web/static/src/js/views/search/search_view.js
+++ b/addons/web/static/src/js/views/search/search_view.js
@@ -4,10 +4,11 @@ odoo.define('web.SearchView', function (require) {
var AutoComplete = require('web.AutoComplete');
var config = require('web.config');
var core = require('web.core');
+var Domain = require('web.Domain');
var FavoriteMenu = require('web.FavoriteMenu');
var FiltersMenu = require('web.FiltersMenu');
var GroupByMenu = require('web.GroupByMenu');
-var pyeval = require('web.pyeval');
+var pyUtils = require('web.py_utils');
var search_inputs = require('web.search_inputs');
var utils = require('web.utils');
var Widget = require('web.Widget');
@@ -21,6 +22,9 @@ var FacetValues = Backbone.Collection.extend({
model: FacetValue
});
+var DEFAULT_INTERVAL = 'month';
+var DEFAULT_PERIOD = 'this_month';
+
var Facet = Backbone.Model.extend({
initialize: function (attrs) {
var values = attrs.values;
@@ -187,10 +191,21 @@ var FacetView = Widget.extend({
}
}
},
- init: function (parent, model, intervalMapping) {
+ /*
+ * @param {Widget} parent
+ * @param {Object} model
+ * @param {Object} intervalMapping, a key is a field name and the corresponding value
+ * is the current interval used
+ * (necessarily the field is of type 'date' or 'datetime')
+ * @param {Object} periodMapping, a key is a field name and the corresponding value
+ * is the current interval used
+ * (necessarily the field is of type 'date' or 'datetime')
+ */
+ init: function (parent, model, intervalMapping, periodMapping) {
this._super(parent);
this.model = model;
this.intervalMapping = intervalMapping;
+ this.periodMapping = periodMapping;
this.model.on('change', this.model_changed, this);
},
destroy: function () {
@@ -205,9 +220,21 @@ var FacetView = Widget.extend({
if (index > 0) {
$('<span/>', {html: self.model.get('separator') || _t(" or ")}).addClass('o_facet_values_sep').appendTo($e);
}
- var couple = _.findWhere(self.intervalMapping, {groupby: value.attributes.value});
- var interval = couple ? couple.interval : undefined;
- return new FacetValueView(self, value, interval).appendTo($e);
+ var couple;
+ var option;
+ if (value.attributes.value && value.attributes.value.attrs) {
+ if (value.attributes.value.attrs.isPeriod) {
+ couple = _.findWhere(self.periodMapping, {filter: value.attributes.value});
+ option = couple ? couple.period : value.attributes.value.attrs.default_period;
+ }
+ if (value.attributes.value.attrs.isDate) {
+ couple = _.findWhere(self.intervalMapping, {groupby: value.attributes.value});
+ option = couple ?
+ couple.interval :
+ (value.attributes.value.attrs.defaultInterval || DEFAULT_INTERVAL);
+ }
+ }
+ return new FacetValueView(self, value, option).appendTo($e);
}));
});
},
@@ -218,21 +245,41 @@ var FacetView = Widget.extend({
var FacetValueView = Widget.extend({
template: 'SearchView.FacetView.Value',
- init: function (parent, model, interval) {
+ /*
+ * @param {Widget} parent
+ * @param {Object} model
+ * @param {Object} interval (optional) is used in case the facet value
+ * corresponds to a groupby with an associated 'date'
+ * 'datetime' field.
+ */
+ init: function (parent, model, option) {
this._super(parent);
this.model = model;
- var intervalDescription = {
+ var optionDescription = _.extend({}, {
day: 'Day',
week: 'Week',
month: 'Month',
quarter: 'Quarter',
year: 'Year',
- };
- // to do: put a test on interval
- if (interval) {
- var intervalLabel = intervalDescription[interval];
- this.intervalLabel = _t(intervalLabel);
+ }, {
+ today: 'Today',
+ this_week: 'This Week',
+ this_month: 'This Month',
+ this_quarter: 'This Quarter',
+ this_year: 'This Year',
+ yesterday: 'Yesterday',
+ last_week: 'Last Week',
+ last_month: 'Last Month',
+ last_quarter: 'Last Quarter',
+ last_year: 'Last Year',
+ last_7_days: 'Last 7 Days',
+ last_30_days: 'Last 30 Days',
+ last_365_days: 'Last 365 Days',
+ });
+ if (option) {
+ var optionLabel = optionDescription[option];
+ this.optionLabel = _t(optionLabel);
}
this.model.on('change', this.model_changed, this);
},
@@ -275,10 +322,10 @@ var SearchView = Widget.extend({
},
},
custom_events: {
- 'menu_item_toggled': '_onItemToggled',
- 'item_option_changed': '_onItemOptionChanged',
- 'new_groupby': '_onNewGroupby',
- 'new_filter': '_onNewFilter',
+ menu_item_toggled: '_onItemToggled',
+ item_option_changed: '_onItemOptionChanged',
+ new_groupby: '_onNewGroupby',
+ new_filters: '_onNewFilters',
},
defaults: _.extend({}, Widget.prototype.defaults, {
hidden: false,
@@ -312,6 +359,8 @@ var SearchView = Widget.extend({
this.action = this.options.action || {};
this.search_fields = [];
+ this.hasFavorites = false;
+
this.selectedGroupIds = {
groupByCategory: [],
filterCategory: []
@@ -320,6 +369,7 @@ var SearchView = Widget.extend({
this.groupbysMapping = [];
this.filtersMapping = [];
this.intervalMapping = [];
+ this.periodMapping = [];
this.filters = [];
this.groupbys = [];
@@ -392,13 +442,15 @@ var SearchView = Widget.extend({
var self = this,
default_custom_filter = this.$buttons && this.favorite_menu && this.favorite_menu.get_default_filter();
if (!self.options.disable_custom_filters && default_custom_filter) {
+ this.hasFavorites = true;
return this.favorite_menu.toggle_filter(default_custom_filter, true);
}
if (!_.isEmpty(this.search_defaults)) {
- var inputs = this.search_fields.concat(this.filters, this.groupbys),
- search_defaults = _.invoke(inputs, 'facet_for_defaults', this.search_defaults);
+ var inputs = this.search_fields.concat(this.filters, this.groupbys);
+ var search_defaults = _.invoke(inputs, 'facet_for_defaults', this.search_defaults);
return $.when.apply(null, search_defaults).then(function () {
- self.query.reset(_(arguments).compact(), {preventSearch: true});
+ var facets = _.compact(arguments);
+ self.query.reset(facets, {preventSearch: true});
});
}
this.query.reset([], {preventSearch: true});
@@ -424,6 +476,9 @@ var SearchView = Widget.extend({
this.trigger_up('search', search);
},
/**
+ * @param {boolean} noDomainEvaluation determines if domain are evaluated or not.
+ * By default, domains are evaluated.
+ *
* Extract search data from the view's facets.
*
* Result is an object with 3 (own) properties:
@@ -437,12 +492,13 @@ var SearchView = Widget.extend({
*
* @return {Object}
*/
- build_search_data: function () {
+ build_search_data: function (noDomainEvaluation) {
var domains = [], contexts = [], groupbys = [];
-
+ noDomainEvaluation = noDomainEvaluation || false;
this.query.each(function (facet) {
+ // field is actually a FilterGroup!
var field = facet.get('field');
- var domain = field.get_domain(facet);
+ var domain = field.get_domain(facet, noDomainEvaluation);
if (domain) {
domains.push(domain);
}
@@ -456,7 +512,6 @@ var SearchView = Widget.extend({
}
});
var intervalMappingNormalized = {};
-
_.each(this.intervalMapping, function (couple) {
var fieldName = couple.groupby.fieldName;
var interval = couple.interval;
@@ -575,7 +630,6 @@ var SearchView = Widget.extend({
groupByCategory: [],
filterCategory: [],
};
-
this.query.each(function (facet) {
if (facet.attributes.cat === "groupByCategory") {
@@ -609,7 +663,7 @@ var SearchView = Widget.extend({
);
}
- var f = new FacetView(this, facet, this.intervalMapping);
+ var f = new FacetView(this, facet, this.intervalMapping, this.periodMapping);
started.push(f.appendTo(self.$('.o_searchview_input_container')));
self.input_subviews.push(f);
}, this);
@@ -669,14 +723,20 @@ var SearchView = Widget.extend({
var category = 'filters';
if (item.attrs.context) {
try {
- var context = pyeval.eval('context', item.attrs.context);
+ var context = pyUtils.eval('context', item.attrs.context);
if (context.group_by) {
category = 'group_by';
item.attrs.fieldName = context.group_by.split(':')[0];
+ item.attrs.isDate = _.contains(['date', 'datetime'], self.fields[item.attrs.fieldName].type);
item.attrs.defaultInterval = context.group_by.split(':')[1];
}
} catch (e) {}
}
+ if (item.attrs.date) {
+ item.attrs.default_period = item.attrs.default_period || DEFAULT_PERIOD;
+ item.attrs.type = self.fields[item.attrs.date].type;
+ }
+ item.attrs.isPeriod = !!item.attrs.date;
return {
item: item,
category: category,
@@ -691,7 +751,7 @@ var SearchView = Widget.extend({
return current_group.push(new search_inputs.Filter(filter.item, self));
}
if (current_group.length) {
- var group = new search_inputs.FilterGroup(current_group, self, self.intervalMapping);
+ var group = new search_inputs.FilterGroup(current_group, self, self.intervalMapping, self.periodMapping);
categories[current_category].push(group);
current_group = [];
}
@@ -704,7 +764,6 @@ var SearchView = Widget.extend({
if (field.type === "many2one" && attrs.widget === "selection") {
attrs.widget = undefined;
}
-
var Obj = core.search_widgets_registry.getAny([attrs.widget, field.type]);
if (Obj) {
self.search_fields.push(new (Obj) (filter.item, field, self));
@@ -738,11 +797,15 @@ var SearchView = Widget.extend({
updateFilters: function (newFilters, filtersToRemove) {
var self = this;
var addedFilters = _.map(newFilters, function (filter) {
+ var domain = filter.domain;
+ if (domain instanceof Array) {
+ domain = Domain.prototype.arrayToString(domain);
+ }
filter = {
- attrs: {domain: filter.domain, help: filter.help},
+ attrs: {domain: domain, help: filter.help},
};
var filterWidget = new search_inputs.Filter(filter);
- var filterGroup = new search_inputs.FilterGroup([filterWidget], self, self.intervalMapping);
+ var filterGroup = new search_inputs.FilterGroup([filterWidget], self, self.intervalMapping, self.periodMapping);
var facet = filterGroup.make_facet([filterGroup.make_value(filter)]);
self.query.add([facet], {silent: true});
@@ -790,14 +853,23 @@ var SearchView = Widget.extend({
group.filters.forEach(function (filter) {
if (!filter.attrs.invisible) {
var filterId = _.uniqueId('__filter__');
+ var isPeriod = filter.attrs.isPeriod;
+ var defaultPeriod = filter.attrs.default_period;
filters.push({
- isActive: !!self.search_defaults[filter.attrs.name],
- description: filter.attrs.string || filter.attrs.help || filter.attrs.name || filter.attrs.domain || 'Ω',
itemId: filterId,
+ description: filter.attrs.string || filter.attrs.help ||
+ filter.attrs.name || filter.attrs.domain || 'Ω',
domain: filter.attrs.domain,
+ fieldName: filter.attrs.date,
+ isPeriod: isPeriod,
+ currentOptionId: defaultPeriod,
+ isActive: !self.hasFavorites && !!self.search_defaults[filter.attrs.name],
groupId: groupId,
});
self.filtersMapping.push({filterId: filterId, filter: filter, groupId: groupId});
+ if (isPeriod) {
+ self.periodMapping.push({filter: filter, period: defaultPeriod, type: filter.attrs.type});
+ }
}
});
self.groupsMapping.push({groupId: groupId, group: group, category: 'Filters'});
@@ -821,20 +893,22 @@ var SearchView = Widget.extend({
var groupId = _.uniqueId('__group__');
group.filters.forEach(function (groupby) {
if (!groupby.attrs.invisible) {
- var fieldName = groupby.attrs.fieldName;
- var defaultOptionId = groupby.attrs.defaultInterval;
var groupbyId = _.uniqueId('__groupby__');
+ var fieldName = groupby.attrs.fieldName;
+ var isDate = groupby.attrs.isDate;
+ var defaultInterval = groupby.attrs.defaultInterval || DEFAULT_INTERVAL;
groupbys.push({
- isActive: !!self.search_defaults[groupby.attrs.name],
- description: groupby.attrs.string,
itemId: groupbyId,
+ description: groupby.attrs.string || groupby.attrs.help || groupby.attrs.name
+ || groupby.attrs.fieldName || 'Ω',
+ isDate: isDate,
fieldName: fieldName,
+ currentOptionId: defaultInterval,
+ isActive: !self.hasFavorites && !!self.search_defaults[groupby.attrs.name],
groupId: groupId,
- defaultOptionId: defaultOptionId,
});
- if (self._fieldIsDate(fieldName)) {
- self.intervalMapping.push({groupby: groupby, interval: defaultOptionId || 'month'});
-
+ if (isDate) {
+ self.intervalMapping.push({groupby: groupby, interval: defaultInterval});
}
self.groupbysMapping.push({groupbyId: groupbyId, groupby: groupby, groupId: groupId});
}
@@ -844,15 +918,6 @@ var SearchView = Widget.extend({
});
return new GroupByMenu(this, groupbys, this.fields);
},
-
-
- _fieldIsDate: function (fieldName) {
- if (_.contains(['date', 'datetime'], this.fields[fieldName].type)) {
- return true;
- }
- return false;
- },
-
/**
* Processes a fieldsView in place. In particular, parses its arch.
*
@@ -869,14 +934,20 @@ var SearchView = Widget.extend({
return fv;
},
/**
+ * This function ask the groupby menu to deactive all groupbys with
+ * corresponding groupId in the list selectedGroupIds.
+ * (TO DO: simplify method... actually there is only one group of groupbys)
+ *
* @private
- * @param {string[]]} selectedGroupIds
+ * @param {string[]]} selectedGroupIds list of group ids to deactivate
*/
_unsetUnusedGroupbys: function (selectedGroupIds) {
- var groupIds = this.selectedGroupIds.groupByCategory.reduce(
- function (acc, id) {
- if (!_.contains(selectedGroupIds, id)) {
- acc.push(id);
+ var groupIds = this.groupsMapping.reduce(
+ function (acc, triple) {
+ if (triple.category === 'Group By') {
+ if (!_.contains(selectedGroupIds, triple.groupId)) {
+ acc.push(triple.groupId);
+ }
}
return acc;
},
@@ -886,14 +957,19 @@ var SearchView = Widget.extend({
this.groupby_menu.unsetGroups(groupIds);
},
/**
+ * This function ask the filters menu to deactive all filters with
+ * corresponding groupId in the list selectedGroupIds.
+ *
* @private
* @param {string[]]} selectedGroupIds
*/
_unsetUnusedFilters: function (selectedGroupIds) {
- var groupIds = this.selectedGroupIds.filterCategory.reduce(
- function (acc, id) {
- if (!_.contains(selectedGroupIds, id)) {
- acc.push(id);
+ var groupIds = this.groupsMapping.reduce(
+ function (acc, triple) {
+ if (triple.category === 'Filters') {
+ if (!_.contains(selectedGroupIds, triple.groupId)) {
+ acc.push(triple.groupId);
+ }
}
return acc;
},
@@ -909,6 +985,11 @@ var SearchView = Widget.extend({
/**
*
+ * this function is called in response to an event 'on_item_toggled'.
+ * this kind of event is triggered by the filters menu or the groupby menu
+ * when a user has clicked on a item (a filter or a groupby).
+ * The query is modified accordingly to the new state (active or not) of that item
+ *
* @private
* @param {OdooEvent} event
*/
@@ -927,27 +1008,36 @@ var SearchView = Widget.extend({
if (event.data.category === 'filterCategory') {
var filter = _.findWhere(this.filtersMapping, {filterId: event.data.itemId}).filter;
group = _.findWhere(this.groupsMapping, {groupId: event.data.groupId}).group;
+ if (event.data.optionId) {
+ var period = event.data.optionId;
+ _.findWhere(this.periodMapping, {filter: filter}).period = period;
+ group.updatePeriodMapping(this.periodMapping);
+ }
group.toggle(filter);
}
},
/**
+ * this function is called when a new groupby has been added to the groupby menu
+ * via the 'Add Custom Groupby' submenu. The query is modified with the new groupby
+ * added to it as active. The communication betwenn the groupby menu and the search view
+ * is maintained by properly updating the mappings.
* @private
* @param {OdooEvent} event
*/
_onNewGroupby: function (event) {
+ var isDate = event.data.isDate;
var attrs = {
- context:"{'group_by':'" + event.data.fieldName + "''}",
- name: event.data.description,
- fieldName: event.data.fieldName,
- };
-
+ context:"{'group_by':'" + event.data.fieldName + "''}",
+ name: event.data.description,
+ fieldName: event.data.fieldName,
+ isDate: isDate,
+ };
var groupby = new search_inputs.Filter({attrs: attrs}, this);
if (event.data.optionId) {
var interval = event.data.optionId;
this.intervalMapping.push({groupby: groupby, interval: interval});
}
- var group = new search_inputs.FilterGroup([groupby], this, this.intervalMapping);
- group.toggle(groupby);
+ var group = new search_inputs.FilterGroup([groupby], this, this.intervalMapping, this.periodMapping);
this.groupbysMapping.push({
groupbyId: event.data.itemId,
groupby: groupby,
@@ -958,44 +1048,49 @@ var SearchView = Widget.extend({
group: group,
category: 'Group By',
});
+ group.toggle(groupby);
},
- /**
+ /**
+ * this function is called when a new filter has been added to the filters menu
+ * via the 'Add Custom Filter' submenu. The query is modified with the new filter
+ * added to it as active. The communication betwenn the filters menu and the search view
+ * is maintained by properly updating the mappings.
* @private
* @param {OdooEvent} event
*/
- _onNewFilter: function (event) {
+ _onNewFilters: function (event) {
var self= this;
var filter;
var filters = [];
var groupId;
_.each(event.data, function (filterDescription) {
- filter = new search_inputs.Filter(filterDescription.filter, this);
- filters.push(filter);
- self.filtersMapping.push({
- filterId: filterDescription.itemId,
- filter: filter,
- groupId: filterDescription.groupId,
- });
- // filters belong to the same group
- if (!groupId) {
- groupId = filterDescription.groupId;
- }
+ filter = new search_inputs.Filter(filterDescription.filter, this);
+ filters.push(filter);
+ self.filtersMapping.push({
+ filterId: filterDescription.itemId,
+ filter: filter,
+ groupId: filterDescription.groupId,
});
- var group = new search_inputs.FilterGroup(filters, this, this.intervalMapping);
+ // filters belong to the same group
+ if (!groupId) {
+ groupId = filterDescription.groupId;
+ }
+ });
+ var group = new search_inputs.FilterGroup(filters, this, this.intervalMapping, this.periodMapping);
filters.forEach(function (filter) {
group.toggle(filter, {silent: true});
});
- this.query.trigger('reset');
-
-
this.groupsMapping.push({
groupId: groupId,
group: group,
category: 'Filters',
});
+ this.query.trigger('reset');
},
/**
+ * this function is called when the option related to an item (filter or groupby) has been
+ * changed by the user. The query is modified appropriately.
*
* @private
* @param {OdooEvent} event
@@ -1012,8 +1107,11 @@ var SearchView = Widget.extend({
}
if (event.data.category === 'filterCategory') {
var filter = _.findWhere(this.filtersMapping, {filterId: event.data.itemId}).filter;
+ var period = event.data.optionId;
+ _.findWhere(this.periodMapping, {filter: filter}).period = period;
group = _.findWhere(this.groupsMapping, {groupId: event.data.groupId}).group;
- group.toggle(filter);
+ group.updatePeriodMapping(this.periodMapping);
+ this.query.trigger('reset');
}
},
});
diff --git a/addons/web/static/src/js/views/view_dialogs.js b/addons/web/static/src/js/views/view_dialogs.js
index 55f9a2e85d7..ed0adf0ff3b 100644
--- a/addons/web/static/src/js/views/view_dialogs.js
+++ b/addons/web/static/src/js/views/view_dialogs.js
@@ -7,7 +7,7 @@ var Dialog = require('web.Dialog');
var dom = require('web.dom');
var ListController = require('web.ListController');
var ListView = require('web.ListView');
-var pyeval = require('web.pyeval');
+var pyUtils = require('web.py_utils');
var SearchView = require('web.SearchView');
var view_registry = require('web.view_registry');
@@ -293,7 +293,7 @@ var SelectCreateDialog = ViewDialog.extend({
var user_context = this.getSession().user_context;
var _super = this._super.bind(this);
- var context = pyeval.eval_domains_and_contexts({
+ var context = pyUtils.eval_domains_and_contexts({
domains: [],
contexts: [user_context, this.context]
}).context;
@@ -397,7 +397,7 @@ var SelectCreateDialog = ViewDialog.extend({
});
},
_process_search_data: function (domains, contexts, groupbys) {
- var results = pyeval.eval_domains_and_contexts({
+ var results = pyUtils.eval_domains_and_contexts({
domains: [this.domain].concat(domains),
contexts: [this.context].concat(contexts),
group_by_seq: groupbys || [],