[FIX] web: do not disable searchpanel on button clicked

Before this rev., the searchpanel was automatically disabled (not
present) in actions obtained by following links or buttons (e.g.
stat buttons).

This rev. removes this constraint, but adds the possibiliy to
disable it by setting key 'search_panel' to false in the context.

Note that in this case, the active categories are never retrieved
from the local storage (i.e. the last one set). If no default is
given, 'All' is simply selected (no domain).

Task 2069310

2 files changed, 20 insertions, 10 deletions

diff --git a/addons/web/static/src/js/views/abstract_view.js b/addons/web/static/src/js/views/abstract_view.js
index d581f84308a..7dc3cc30563 100644
--- a/addons/web/static/src/js/views/abstract_view.js
+++ b/addons/web/static/src/js/views/abstract_view.js
@@ -91,8 +91,8 @@ var AbstractView = Factory.extend({
      * @param {Array[]} [params.searchQuery.domain=[]]
      * @param {string[]} [params.searchQuery.groupBy=[]]
      * @param {Object} [params.userContext={}]
-     * @param {boolean} [params.withControlPanel=true]
-     * @param {boolean} [params.withSearchPanel=true]
+     * @param {boolean} [params.withControlPanel=AbstractView.prototype.withControlPanel]
+     * @param {boolean} [params.withSearchPanel=AbstractView.prototype.withSearchPanel]
      */
     init: function (viewInfo, params) {
         this._super.apply(this, arguments);
@@ -115,7 +115,9 @@ var AbstractView = Factory.extend({
         this.fields = this.fieldsView.viewFields;
         this.userContext = params.userContext || {};
         this.withControlPanel = this.withControlPanel && params.withControlPanel;
-        this.withSearchPanel = this.withSearchPanel && this.multi_record && params.withSearchPanel;
+        const searchPanelDisabled = 'search_panel' in params.context && !params.search_panel;
+        this.withSearchPanel = this.withSearchPanel && this.multi_record &&
+                               params.withSearchPanel && !searchPanelDisabled;
 
         // the boolean parameter 'isEmbedded' determines if the view should be
         // considered as a subview. For now this is only used by the graph
@@ -187,6 +189,9 @@ var AbstractView = Factory.extend({
             withSearchBar: params.withSearchBar,
         };
         this.searchPanelParams = {
+            defaultNoFilter: params.searchPanelDefaultNoFilter,
+            fields: this.fields,
+            model: this.loadParams.modelName,
             state: controllerState.spState,
         };
     },
@@ -292,15 +297,12 @@ var AbstractView = Factory.extend({
             }
         });
         var controlPanelDomain = this.loadParams.domain;
-        var searchPanel = new this.config.SearchPanel(parent, {
+        var spParams = _.extend({}, this.searchPanelParams, {
             defaultValues: defaultValues,
-            fields: this.fields,
-            model: this.loadParams.modelName,
             searchDomain: controlPanelDomain,
-            sections: this.searchPanelParams.sections,
-            state: this.searchPanelParams.state,
             classes: params.classes || [],
         });
+        var searchPanel = new this.config.SearchPanel(parent, spParams);
         this.controllerParams.searchPanel = searchPanel;
         this.controllerParams.controlPanelDomain = controlPanelDomain;
         await searchPanel.appendTo(document.createDocumentFragment());
diff --git a/addons/web/static/src/js/views/search_panel.js b/addons/web/static/src/js/views/search_panel.js
index 32bfda12594..d222a5642cf 100644
--- a/addons/web/static/src/js/views/search_panel.js
+++ b/addons/web/static/src/js/views/search_panel.js
@@ -77,6 +77,9 @@ var SearchPanel = Widget.extend({
      * @param {Object} params
      * @param {Object} [params.defaultValues={}] the value(s) to activate by
      *   default, for each filter and category
+     * @param {boolean} [params.defaultNoFilter=false] if true, select 'All' as
+     *   value for each category that has no value specified in defaultValues
+     *   (instead of looking in the localStorage for the last selected value)
      * @param {Object} params.fields
      * @param {string} params.model
      * @param {Array[]} params.searchDomain domain coming from controlPanel
@@ -97,6 +100,12 @@ var SearchPanel = Widget.extend({
         this.initialState = params.state;
         this.scrollTop = this.initialState && this.initialState.scrollTop || null;
         this.defaultValues = params.defaultValues || {};
+        if (params.defaultNoFilter) {
+            Object.keys(this.categories).forEach((categoryId) => {
+                var fieldName = this.categories[categoryId].fieldName;
+                this.defaultValues[fieldName] = this.defaultValues[fieldName] || false;
+            });
+        }
         this.fields = params.fields;
         this.model = params.model;
         this.className = params.classes.concat(['o_search_panel']).join(' ');
@@ -181,7 +190,7 @@ var SearchPanel = Widget.extend({
         return {
             sections: searchPanelSections,
             classes: classes,
-        }
+        };
     },
     /**
      * Export the current state (categories and filters) of the searchpanel.
@@ -293,7 +302,6 @@ var SearchPanel = Widget.extend({
         // set active value
         var validValues = _.pluck(category.values, 'id').concat([false]);
         var value = this._getCategoryDefaultValue(category, validValues);
-        // if not set in localStorage either, select 'All'
         category.activeValueId = _.contains(validValues, value) ? value : false;
 
         // unfold ancestor values of active value to make it is visible