summaryrefslogtreecommitdiff
path: root/addons/web/static/src/js/views/form
diff options
context:
space:
mode:
authorAaron Bohy <aab@odoo.com>2020-04-03 09:37:39 +0000
committerAaron Bohy <aab@odoo.com>2020-04-03 11:41:05 +0000
commit147d7e8910a7745fce738825a1deda54972f792b (patch)
tree9a3ecc514ebd9ac69d33d202c9f43f2e74d74fa2 /addons/web/static/src/js/views/form
parent540df68b325d775fdccfe69d82cbb01a39b3a680 (diff)
[FIX] web: form: hide labels of oe_(read|edit)_only fields
In a form view, nodes with classname "oe_read_only" (resp. "oe_edit_only") are only visible in readonly (resp. edit) mode. Moreover, fields inside a group automatically have an associated label. Before this commit, when one of these classnames was set on a field node inside a group, the effect wasn't applied on its label, so the label was always visible, even if the field was hidden. Bug reported in PR odoo/odoo#48699 closes odoo/odoo#48968 X-original-commit: 705f434f0f18a0e4d2fdb0f86d3e350d190b2a30 Signed-off-by: Julien Mougenot (jum) <jum@odoo.com> Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
Diffstat (limited to 'addons/web/static/src/js/views/form')
-rw-r--r--addons/web/static/src/js/views/form/form_renderer.js8
1 files changed, 8 insertions, 0 deletions
diff --git a/addons/web/static/src/js/views/form/form_renderer.js b/addons/web/static/src/js/views/form/form_renderer.js
index a258d16a917..18a5695005f 100644
--- a/addons/web/static/src/js/views/form/form_renderer.js
+++ b/addons/web/static/src/js/views/form/form_renderer.js
@@ -608,6 +608,14 @@ var FormRenderer = BasicRenderer.extend({
if (node.attrs.nolabel !== '1') {
var $labelTd = this._renderInnerGroupLabel(node);
$tds = $labelTd.add($tds);
+
+ // apply the oe_(edit|read)_only className on the label as well
+ if (/\boe_edit_only\b/.test(node.attrs.class)) {
+ $tds.addClass('oe_edit_only');
+ }
+ if (/\boe_read_only\b/.test(node.attrs.class)) {
+ $tds.addClass('oe_read_only');
+ }
}
return $tds;