summaryrefslogtreecommitdiff
path: root/addons/web/static/src/js/views/basic
diff options
context:
space:
mode:
authorJoren Van Onder <jov@odoo.com>2020-02-13 18:40:46 +0000
committerJoren Van Onder <jov@odoo.com>2020-02-14 08:44:12 +0000
commitaa343d17f700d33b4e11b3ee9bb3b9b2b0353874 (patch)
tree9912caf6c800c5d41f7bd4ec04935cb56022e541 /addons/web/static/src/js/views/basic
parentb08729267b88a0139c46bd7ecbca49db24904de4 (diff)
[FIX] payment_authorize: always send an amount with the correct decimals
We cannot assume reading the value of a monetary field has the decimals specified by the currency in decimal_places. Right after creating a record with a monetary field it may have a different amount of decimals. To reproduce this: >>> tx = env['payment.transaction'].create({ 'amount': 10.87, 'acquirer_id': env['payment.acquirer'].search([], limit=1).id, 'currency_id': env.ref('base.USD').id, 'reference': 'test' }) >>> tx.id 130 >>> tx.amount 10.870000000000001 <Restart odoo> >>> env['payment.transaction'].browse(130).amount 10.87 Authorize requires us to send a correctly rounded amount. The following response is returned when sending 10.870000000000001: {'messages': {'message': [{'code': 'E00027', 'text': 'The transaction was unsuccessful.'}], 'resultCode': 'Error'}, 'transactionResponse': {'SupplementalDataQualificationIndicator': 0, 'accountNumber': '', 'accountType': '', 'authCode': '', 'avsResultCode': 'P', 'cavvResultCode': '', 'cvvResultCode': '', 'errors': [{'errorCode': '5', 'errorText': 'A valid amount is ' 'required.'}], 'refTransID': '', 'responseCode': '3', 'testRequest': '0', 'transHash': '', 'transHashSha2': '', 'transId': '0'}} To work around the issue always round when we read amount. Lower level solutions were considered in #45248 but for now we'll stick with this higher level and lower risk patch. opw-2188889 closes odoo/odoo#45362 X-original-commit: 7485927f0eb152086efcaaf4a30260e503267c41 Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
Diffstat (limited to 'addons/web/static/src/js/views/basic')
0 files changed, 0 insertions, 0 deletions