[FIX] web: better handling for readonly modifiers

Before this commit, the web client read the readonly in the modifiers,
and if no readonly was in the modifiers, it fell back to the field
property.  But the field property was already taken into account in the
modifiers, so this was useless.  And worse, in some case, it could cause
an issue.  For example, a field with readonly=true, and readonly="0" in
the arch was considered readonly.

1 files changed, 2 insertions, 5 deletions

diff --git a/addons/web/static/src/js/views/basic/basic_model.js b/addons/web/static/src/js/views/basic/basic_model.js
index 01b2a18091a..61c153e9032 100644
--- a/addons/web/static/src/js/views/basic/basic_model.js
+++ b/addons/web/static/src/js/views/basic/basic_model.js
@@ -2539,15 +2539,12 @@ var BasicModel = AbstractModel.extend({
      */
     _isFieldReadonly: function (record, fieldName, viewType) {
         var fieldInfo = record.fieldsInfo[viewType || record.viewType][fieldName];
-        var modifiers;
         if (fieldInfo) {
             var rawModifiers = JSON.parse(fieldInfo.modifiers || "{}");
-            modifiers = this._evalModifiers(record, rawModifiers);
-        }
-        if (modifiers && 'readonly' in modifiers) {
+            var modifiers = this._evalModifiers(record, rawModifiers);
             return modifiers.readonly;
         } else {
-            return record.fields[fieldName].readonly;
+            return false;
         }
     },
     /**