summaryrefslogtreecommitdiff
path: root/addons/web/static/src/js/views/basic
diff options
context:
space:
mode:
authorAaron Bohy <aab@odoo.com>2017-05-18 13:16:48 +0200
committerAaron Bohy <aab@odoo.com>2017-05-18 13:55:46 +0200
commit8af3d452f414135bd897026859958a9660bb5aa4 (patch)
treec195263538f06ca6d530c0a80a95aa17b1bf09c7 /addons/web/static/src/js/views/basic
parentf77e86b67ba8e8654d6f051239bacb0efdb8d7b1 (diff)
[FIX] web: BasicModel: read_group on selection field
When grouping on a selection field, the read_group may return a group for value false (containing records with the selection field unset, typically). When this happened, there was a crash because the BasicModel didn't handle that case (it assumed that the value of the groups was always a valid key of the selection).
Diffstat (limited to 'addons/web/static/src/js/views/basic')
-rw-r--r--addons/web/static/src/js/views/basic/basic_model.js2
1 files changed, 1 insertions, 1 deletions
diff --git a/addons/web/static/src/js/views/basic/basic_model.js b/addons/web/static/src/js/views/basic/basic_model.js
index eef42f19bc3..37adddfcd75 100644
--- a/addons/web/static/src/js/views/basic/basic_model.js
+++ b/addons/web/static/src/js/views/basic/basic_model.js
@@ -2576,7 +2576,7 @@ var BasicModel = AbstractModel.extend({
var choice = _.find(list.fields[rawGroupBy].selection, function (c) {
return c[0] === value;
});
- value = choice[1];
+ value = choice ? choice[1] : false;
}
var newGroup = self._makeDataPoint({
modelName: list.model,