summaryrefslogtreecommitdiff
path: root/addons/web/static/src/js/views/basic/basic_view.js
diff options
context:
space:
mode:
authorGéry Debongnie <ged@odoo.com>2017-02-24 11:06:06 +0100
committerAaron Bohy <aab@odoo.com>2017-04-11 19:44:38 +0200
commit7c41254d8f5474deb755fbd5ff9ce6f40576fa5e (patch)
treeaf05fd170e1180c8e043697ef60bfa3d8cabdf29 /addons/web/static/src/js/views/basic/basic_view.js
parent0c1d9204c3f38770be6a1bcb7bd9288cd60b9508 (diff)
[REF] web: small linting pass, add some comments, update style
Diffstat (limited to 'addons/web/static/src/js/views/basic/basic_view.js')
-rw-r--r--addons/web/static/src/js/views/basic/basic_view.js24
1 files changed, 12 insertions, 12 deletions
diff --git a/addons/web/static/src/js/views/basic/basic_view.js b/addons/web/static/src/js/views/basic/basic_view.js
index 1601cf4c350..947a3ad26b6 100644
--- a/addons/web/static/src/js/views/basic/basic_view.js
+++ b/addons/web/static/src/js/views/basic/basic_view.js
@@ -53,9 +53,9 @@ var BasicView = AbstractView.extend({
var result = this._processFieldsView(arch, fields);
var fieldAttrs = result.fieldAttrs;
- var view_fields = result.view_fields;
- var fieldNames = _.keys(view_fields);
- fields = _.defaults(view_fields, fields);
+ var viewFields = result.view_fields;
+ var fieldNames = _.keys(viewFields);
+ fields = _.defaults(viewFields, fields);
var self = this;
// process the inner fields_view as well to find the fields they use.
// register those fields' description directly on the view.
@@ -63,12 +63,12 @@ var BasicView = AbstractView.extend({
// basically the field_names will be the keys of the fields obj.
// don't use _ to iterate on fields in case there is a 'length' field,
// as _ doesn't behave correctly when there is a length key in the object
- for (var field_name in fields) {
- var field = fields[field_name];
- _.each(field.views, function (inner_fields_view) {
- result = self._processFieldsView(inner_fields_view.arch, inner_fields_view.fields);
- inner_fields_view.fieldAttrs = result.fieldAttrs;
- inner_fields_view.fields = result.view_fields;
+ for (var fieldName in fields) {
+ var field = fields[fieldName];
+ _.each(field.views, function (innerFieldsView) {
+ result = self._processFieldsView(innerFieldsView.arch, innerFieldsView.fields);
+ innerFieldsView.fieldAttrs = result.fieldAttrs;
+ innerFieldsView.fields = result.view_fields;
});
if (field.type === 'one2many' || field.type === 'many2many') {
if (field.views && field.views.tree) {
@@ -114,7 +114,7 @@ var BasicView = AbstractView.extend({
*/
_processFieldsView: function (arch, fields) {
var self = this;
- var view_fields = Object.create(null);
+ var viewFields = Object.create(null);
var fieldAttrs = Object.create(null);
traverse(arch, function (node) {
if (typeof node === 'string') {
@@ -124,14 +124,14 @@ var BasicView = AbstractView.extend({
var attrs = node.attrs || {};
var field = _.extend({}, fields[node.attrs.name]);
self._processField(field, node, attrs);
- view_fields[node.attrs.name] = field;
+ viewFields[node.attrs.name] = field;
fieldAttrs[node.attrs.name] = attrs;
return false;
}
return node.tag !== 'arch';
});
return {
- view_fields: view_fields,
+ view_fields: viewFields,
fieldAttrs: fieldAttrs,
};
},