summaryrefslogtreecommitdiff
path: root/addons/web/static/src/js/views/basic/basic_view.js
diff options
context:
space:
mode:
authorGéry Debongnie <ged@odoo.com>2018-04-13 13:01:09 +0200
committerGéry Debongnie <ged@odoo.com>2018-04-13 17:14:49 +0200
commit1d8466ab54350d290cb7fb21a9b1a57191184494 (patch)
tree01e1eb89338f9a3f88560bb740e39cee6c1b8bc6 /addons/web/static/src/js/views/basic/basic_view.js
parent8bdc650f79e0e35de152d456cc9cc565db46a027 (diff)
[FIX] mail: prevent race conditions in discuss
The discuss application starting process is strongly asynchronous. However, it relies implicitely on the fact that the widget is not destroyed in its starting process. For example, if the widget is detroyed before the updateChannel method is called, then any call to the chat manager service will return undefined and the widget will crash. When discuss is destroyed exactly between the start and the end of the creation of its search view (which is asynchronous), then it is possible to have a crash, because the search view will be destroyed when the do_search method is called. Note that we had to fix discuss mobile as well: The _setChannel method is supposed to return a deferred, but the mobile override did not return it. As a result, a test in the mobile suite failed because this.alive takes a deferred in argument.
Diffstat (limited to 'addons/web/static/src/js/views/basic/basic_view.js')
0 files changed, 0 insertions, 0 deletions