diff options
| author | Denis Ledoux <dle@odoo.com> | 2020-02-26 09:16:01 +0000 |
|---|---|---|
| committer | Denis Ledoux <dle@odoo.com> | 2020-03-18 11:18:31 +0000 |
| commit | ceb1acd6d4c121d6b37ff8410bd81a046e447026 (patch) | |
| tree | ae1aeedddc62647f21be0eafff355571dd210980 /addons/web/static/src/js/views/basic/basic_renderer.js | |
| parent | 375179ed54c502e9c31295691252015b5bcfe6c4 (diff) | |
[FIX] base: validate `ir.ui.view` xml on re-enabling
When passing a view
from `active` `False`
to `active` `True`,
its xml wasn't being checked, and it could be very well be invalid.
e.g.
Create a view inheriting from `base.view_partner_form`
`active` set to `False`
`arch` set to
```
<field name="foo" position="after">
<field name="bar"/>
</field>
```
On creation, the `_check_xml` constraint is valid because the view is disabled.
Now, write `active` to `True`. Notice no constraint error is raised while the view is invalid.
This is particularly critical now that we automatically disable invalid custom views
during upgrades. When the user tries to re-enable the view which has been disabled to see
what was wrong, he doesn't get any error because of this.
closes odoo/odoo#47897
X-original-commit: fb2aeb29cd62e02ca5485e5b60d6b61ae4acc252
Signed-off-by: Denis Ledoux (dle) <dle@odoo.com>
Diffstat (limited to 'addons/web/static/src/js/views/basic/basic_renderer.js')
0 files changed, 0 insertions, 0 deletions
