summaryrefslogtreecommitdiff
path: root/addons/web/static/src/js/views/basic/basic_renderer.js
diff options
context:
space:
mode:
authorGéry Debongnie <ged@odoo.com>2018-04-11 10:36:25 +0200
committerGéry Debongnie <ged@odoo.com>2018-04-11 11:51:49 +0200
commit86897ca167338ca434e62827fa09f44ddbce324c (patch)
treeec00472e2fc0309c34e8cd6129deeaae85cfeb49 /addons/web/static/src/js/views/basic/basic_renderer.js
parentf39b1bb4467e5c0da7d2b52cf69e27175d1247a9 (diff)
[REF] web: remove updateModifiersValue from widget
The keyboard shortcut branch recently added a method updateModifiersValue on the widget class, which is used to make a widget aware of its modifier status (in particular, if it is required). This is necessary for the proper navigation behaviour on field widgets, but should not be on the widget class. The proper fix is, in my opinion, to introduce a AbstractViewWidget class which would be used for AbstractField and all custom widgets in views. Meanwhile, this commit simply protects the call to that method. This is a refactoring, but can be merged in saas-11.3.
Diffstat (limited to 'addons/web/static/src/js/views/basic/basic_renderer.js')
-rw-r--r--addons/web/static/src/js/views/basic/basic_renderer.js2
1 files changed, 1 insertions, 1 deletions
diff --git a/addons/web/static/src/js/views/basic/basic_renderer.js b/addons/web/static/src/js/views/basic/basic_renderer.js
index 55a6c7a6c94..80cdd05bff5 100644
--- a/addons/web/static/src/js/views/basic/basic_renderer.js
+++ b/addons/web/static/src/js/views/basic/basic_renderer.js
@@ -278,7 +278,7 @@ var BasicRenderer = AbstractRenderer.extend({
element.$el.toggleClass("o_readonly_modifier", !!modifiers.readonly);
element.$el.toggleClass("o_required_modifier", !!modifiers.required);
- if (element.widget) {
+ if (element.widget && element.widget.updateModifiersValue) {
element.widget.updateModifiersValue(modifiers);
}