diff options
| author | mgh-odoo <mgh@odoo.com> | 2018-07-12 10:43:07 +0000 |
|---|---|---|
| committer | Géry Debongnie <ged@odoo.com> | 2018-12-19 10:28:17 +0000 |
| commit | 6be0cdef98fdafc2cb90042758de1b756e955624 (patch) | |
| tree | f0dd8a7a8bf200997bb8eb3dab14d120596de48d /addons/web/static/src/js/views/basic/basic_renderer.js | |
| parent | fa9874915449896ff770adbb63780629c18b3e7b (diff) | |
[FIX] web: remove extra space in kanban dragging images
While dragging kanban record which have a cover image set, the kanban view
creates extra space, which makes it difficult to properly target a
position.
This is because of a jquery.ui issue for sortable when helper=clone is used.
In that case, then jquery.ui sortable will create a clone of current element
after hiding it. Note that jquery.ui tries to get height to current dragged
element after making it hidden(display: none) and display: none, so the element
does not return actual height and hence it gives innerHeight which considers
height of the image also and extra space is generated.
An alternative solution is to add start event in sortable option and
1) show ui.item
2) get height of the element and
3) hide ui.item, which gives proper height of the current dragged element
But removing helper=clone will also fix the issue and is not actually required.
Note that some special care had to be done to prevent the click from the
drag and drop operation to actually open the record.
Related to task: #1865788
Closes: #25734
closes odoo/odoo#29642
Diffstat (limited to 'addons/web/static/src/js/views/basic/basic_renderer.js')
0 files changed, 0 insertions, 0 deletions
