diff options
| author | Romain Derie <rde@odoo.com> | 2019-07-19 14:50:15 +0000 |
|---|---|---|
| committer | Romain Derie <rde@odoo.com> | 2019-07-22 08:30:21 +0000 |
| commit | ac170e8a8238a9b0aa468f83b11aabc4cd9493de (patch) | |
| tree | 7d9cd31f661c5e601bfd0dec275b3666b5a885a0 /addons/web/static/src/js/views/basic/basic_model.js | |
| parent | eb4700f17f5fa2fb10e2170642b8e56291f77a36 (diff) | |
[FIX] web_editor, website: stop snippet animations before cloning
Before this commit, when a snippet was cloned, its animation was not destroyed
first. The flow was:
1. Clone the snippet (DOM) - web_editor trigger `snippet_cloned`
2. Start cloned snippet animation - website listen `snippet_cloned`
This was causing bugs, eg facebook snippet for which the animation is to create
an iframe containing the facebook widget.
When cloning this snippet, its iframe would be cloned to, then its animation
would be started, creating another iframe.
To fix such flows, the snippet cloning flow should be:
1. Strop the snippet animation
2. Clone the snippet (DOM) - web_editor trigger `snippet_cloned`
3. Start cloned snippet animation - website listen `snippet_cloned`
4. Restart the original snippet animation
task-1951466
closes odoo/odoo#35029
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Diffstat (limited to 'addons/web/static/src/js/views/basic/basic_model.js')
0 files changed, 0 insertions, 0 deletions
