diff options
| author | Jairo Llopis <yajo.sk8@gmail.com> | 2019-07-08 10:57:40 +0000 |
|---|---|---|
| committer | Jairo Llopis <yajo.sk8@gmail.com> | 2019-07-09 07:14:57 +0000 |
| commit | fb95cf7b518c21ce5eda58894c1caa861f8b72f8 (patch) | |
| tree | 79213ea62df62584509c3066e27a641bb5da0978 /addons/web/static/src/js/views/basic/basic_controller.js | |
| parent | b5f61bfaadbb7107b6753870feb02212be5d0ca1 (diff) | |
[FIX] mass_mailing: Do not alter method signature
Before this patch, this method was altering the signature of its parent method, moving the position of `failure_type` to 1 and making the other 2 arguments kw-only.
It seems this accidentally didn't break anything because all calls happened to be done in kwarg mode. However, it's very possible that a downstream module that is not based on `mass_mailing` and makes positional calls gets broken when `mass_mailing` is installed.
The fix is to respect original method signature.
closes odoo/odoo#34648
Signed-off-by: Xavier Dollé (xdo) <xdo@odoo.com>
Diffstat (limited to 'addons/web/static/src/js/views/basic/basic_controller.js')
0 files changed, 0 insertions, 0 deletions