summaryrefslogtreecommitdiff
path: root/addons/web/static/src/js/views/basic/basic_controller.js
diff options
context:
space:
mode:
authorRobot Odoo <xmo+roboto@odoo.com>2019-04-18 11:01:15 +0200
committerGitHub <noreply@github.com>2019-04-18 11:01:15 +0200
commit7aa1e727798ac58375c96bbab634a20f33fad427 (patch)
tree62100bf29c4043ddad695ed850921e88571cafd8 /addons/web/static/src/js/views/basic/basic_controller.js
parentab4f5b1ff303a693c2903226e048defa028e76a5 (diff)
parentad8e969323ef504f6f4a745ceeac6d0d2b19a91d (diff)
[IMP] mail: Delete tracking values when uninstalling module
[IMP] mail: Delete tracking values when uninstalling module -------------- ### Purpose mail.tracking.values should be deleted when the corresponding field is deleted (when the module which defined it is uninstalled). Firstly because we don't want useless data in db. Secondly because the groups associated with the field can no longer be checked if it was deleted. As we don't know to whom the value was restricted, the value should not be displayed anyway. Note: this case was fixed in saas-12.2 by b9e96b7 but the proper way to fix it is to delete the tracking values. ### Specification Delete `mail.tracking.value` when the associated `ir.model.fields` is deleted. Two alternatives were considered: 1. Change the `field` field of `mail.tracking.value` from Char to a m2o to `ir.model.fields` which allows to use delete oncascade. This implies to modify existing code, but more importantly it adds database queries. 2. Override the unlink method of `ir.model.fields` to first unlink associated tracking values. The first method is probably cleaner but the second method was nonetheless chosen as we don't want to impact performance in the main tracking flow only to better support module uninstalls which happens rarely. Note: when a module is uninstalled, `ir.model.fields` are unlinked one by one (in a for loop). Tracking values are therefore also unlinked field by field. Batchifying field deletion would greatly reduce the amount of queries. [IMP] mail: Rename groups field of mail.tracking.value ---------------- This commit renames the `groups` field into `field_groups`. The previous name was impossible to grep as the word `groups` is everywhere in the code base. Also the new name better follows the implicit convention that fields related to the tracked field all start with `field_`. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr closes odoo/odoo#31861 Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
Diffstat (limited to 'addons/web/static/src/js/views/basic/basic_controller.js')
0 files changed, 0 insertions, 0 deletions