diff options
| author | Cedric Snauwaert <csn@openerp.com> | 2019-03-15 13:01:00 +0000 |
|---|---|---|
| committer | Cedric Snauwaert <csn@openerp.com> | 2019-03-15 13:01:03 +0000 |
| commit | 1834b80bfa2e259b0127d462a84225fab14fe39d (patch) | |
| tree | 03991b1af288149d14ba477eccc4b39528be3f01 /addons/web/static/src/js/views/basic/basic_controller.js | |
| parent | f3ea68c9098c1f4ca5a459ffe0d10f9417718af2 (diff) | |
[FIX] account: error in concurrent update while reconciling
In reconciliation widget, when clicking reconcile with some existing line. if by any chance the transaction gets rolled back because of a concurrent update, the next replay attempt will use the modified parameters, and we will get a KeyError. Retrying the operation will succeed as soon as no other transaction conflicts again.
Altering mutable RPC parameters is a bit risky in a public RPC method, particularly when those altered parameters will modify the effect of the method. Making a deepcopy of the parameters before using them is an easy workaround. The framework does not do it by default because of the hard-to-foresee memory overhead it would have.
fixes #25403
closes odoo/odoo#31882
Signed-off-by: Cedric Snauwaert (csn) <csn@openerp.com>
Diffstat (limited to 'addons/web/static/src/js/views/basic/basic_controller.js')
0 files changed, 0 insertions, 0 deletions
