summaryrefslogtreecommitdiff
path: root/addons/web/static/src/js/views/basic/basic_controller.js
diff options
context:
space:
mode:
authorAlexandre Kühn <aku@odoo.com>2019-03-27 13:52:46 +0000
committerAlexandre Kühn <aku@odoo.com>2019-03-27 14:27:11 +0000
commit05e480acb1ad33baabcf701b670ab5c6e559b4f1 (patch)
tree33ae3fd8f4186af7f1e25b371596364a9a77e4c7 /addons/web/static/src/js/views/basic/basic_controller.js
parentce4713cd0e790a88daefd727b5e4ebad4df0e2f0 (diff)
[FIX] im_livechat: open website livechat window
Before this commit, when opening a website livechat window, it crashed with the following error message in the dev tools: ``` Cannot read property 'html' of `undefined` ``` The problem was caused by the rendering of the chat window header before the chat window widget is even mounted in the DOM. This error has been introduced by the migration from jQuery 1.12 to 3, in which most occurrences of `$.Deferred` have been turned into `Promise` [1]. `Widget.appendTo()` returns a `Promise` (was `$.Deferred` before). A `Promise` is always asynchronous, whereas a `$.Deferred` with jQuery 1.12 may be either synchronous or asynchronous. In the case of the website livechat window, the implementation with `$.Deferred` was always synchronous, which is no longer the case now. [1] https://github.com/odoo/odoo/commit/126fb33f6a74916c808c8e988f55faf82f0b5759 closes odoo/odoo#32168 Signed-off-by: Jérome Maes (jem) <jem@openerp.com>
Diffstat (limited to 'addons/web/static/src/js/views/basic/basic_controller.js')
0 files changed, 0 insertions, 0 deletions