diff options
| author | Xavier Morel <xmo@openerp.com> | 2011-11-10 16:23:13 +0100 |
|---|---|---|
| committer | Xavier Morel <xmo@openerp.com> | 2011-11-10 16:23:13 +0100 |
| commit | 78dec879cfa55787813bbd7bb222bddbf7d36aee (patch) | |
| tree | 35ddc46dfb49bda7cfa1fd627409917502762256 /addons/web/static/src/js/dates.js | |
| parent | 126a9129a6fc527fde29c832d1318f56cd40ca36 (diff) | |
[IMP] throw actual errors in formatting functions, in order for browser devtools to be useful
throwing strings prevents browser devtools/consoles from using traceback information (because there isn't any on strings)
bzr revid: xmo@openerp.com-20111110152313-phgtr24gyu2ltjn7
Diffstat (limited to 'addons/web/static/src/js/dates.js')
| -rw-r--r-- | addons/web/static/src/js/dates.js | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/addons/web/static/src/js/dates.js b/addons/web/static/src/js/dates.js index 036cf8cd90b..7861dd21b79 100644 --- a/addons/web/static/src/js/dates.js +++ b/addons/web/static/src/js/dates.js @@ -18,11 +18,11 @@ openerp.web.str_to_datetime = function(str) { var regex = /^(\d\d\d\d-\d\d-\d\d \d\d:\d\d:\d\d)(?:\.\d+)?$/; var res = regex.exec(str); if ( !res ) { - throw "'" + str + "' is not a valid datetime"; + throw new Error("'" + str + "' is not a valid datetime"); } var obj = Date.parse(res[1] + " GMT"); if (! obj) { - throw "'" + str + "' is not a valid datetime"; + throw new Error("'" + str + "' is not a valid datetime"); } return obj; }; @@ -41,11 +41,11 @@ openerp.web.str_to_date = function(str) { var regex = /^\d\d\d\d-\d\d-\d\d$/; var res = regex.exec(str); if ( !res ) { - throw "'" + str + "' is not a valid date"; + throw new Error("'" + str + "' is not a valid date"); } var obj = Date.parse(str); if (! obj) { - throw "'" + str + "' is not a valid date"; + throw new Error("'" + str + "' is not a valid date"); } return obj; }; @@ -64,11 +64,11 @@ openerp.web.str_to_time = function(str) { var regex = /^(\d\d:\d\d:\d\d)(?:\.\d+)?$/; var res = regex.exec(str); if ( !res ) { - throw "'" + str + "' is not a valid time"; + throw new Error("'" + str + "' is not a valid time"); } var obj = Date.parse(res[1]); if (! obj) { - throw "'" + str + "' is not a valid time"; + throw new Error("'" + str + "' is not a valid time"); } return obj; }; |
