diff options
| author | fka-odoo <fka@openerp.com> | 2014-07-02 14:08:41 +0530 |
|---|---|---|
| committer | Martin Trigaux <mat@openerp.com> | 2014-09-11 17:38:40 +0200 |
| commit | 875d7ed38ec05daa5d91229cd0a085023b47810d (patch) | |
| tree | 85897b5803cbdab3cf7541c3680ecc9ecb2988a2 /addons/web/static/src/js/data.js | |
| parent | 8c3924165176571120cb416bb7d9e0dcfe9afb91 (diff) | |
[FIX] web: sort with undefined value
In this awesome programming language called javascript, undefined is neither bigger nor smaller than a string. Previous code was then considering undefined values equal to any string.
This fix allows to sort in a column of a o2m field and group the undefined values together. opw 607704
Diffstat (limited to 'addons/web/static/src/js/data.js')
| -rw-r--r-- | addons/web/static/src/js/data.js | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/addons/web/static/src/js/data.js b/addons/web/static/src/js/data.js index 6ae69fbe67b..5553572a12e 100644 --- a/addons/web/static/src/js/data.js +++ b/addons/web/static/src/js/data.js @@ -898,6 +898,8 @@ instance.web.BufferedDataSet = instance.web.DataSetStatic.extend({ sign = -1; field = field.slice(1); } + if(!a[field] && a[field] !== 0){ return sign} + if(!b[field] && b[field] !== 0){ return (sign == -1) ? 1 : -1} //m2o should be searched based on value[1] not based whole value(i.e. [id, value]) if(_.isArray(a[field]) && a[field].length == 2 && _.isString(a[field][1])){ return sign * compare(a[field][1], b[field][1]); |