diff options
| author | fja-odoo <fja@odoo.com> | 2019-07-25 08:20:59 +0000 |
|---|---|---|
| committer | fja-odoo <fja@odoo.com> | 2019-07-30 15:57:14 +0000 |
| commit | 2d6dc75a2cb5fa81189920d0f7fdc7b7f12132ab (patch) | |
| tree | 676231ee9b42ca9957936023ada029784889deec /addons/web/static/src/js/core | |
| parent | caf6cb929b852209e84fa23efd10f58651d18d8e (diff) | |
[FIX] web, *: make crash_manager use services correctly
* = website_forum, stock
Fix for: https://github.com/odoo/odoo/pull/32132
crash_manager.js was using the services while bypassing
ServiceProviderMixin That means all services are duplicated, each having
their own state.
To fix this issue, CrashManager now extends AbstractService. Also
crash_manager is now registered in serviceRegistry instead of being
instanciated on the fly.
The crash_manager now being a Service raise one issue with the tests:
The services are not run for the tests but some tests needs the
crash_manager 'unhandledrejection' listener. For that matter the
services are reenable in qunit. Also the crash_manager's
'unhandledrejection' listener has to have precedence over the qunit
listener as it will handle rejections wich have no reason or are not
Errors.
Part of: https://github.com/odoo/odoo/pull/35209
Diffstat (limited to 'addons/web/static/src/js/core')
| -rw-r--r-- | addons/web/static/src/js/core/misc.js | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/addons/web/static/src/js/core/misc.js b/addons/web/static/src/js/core/misc.js index 39fd8021071..6260a4ab583 100644 --- a/addons/web/static/src/js/core/misc.js +++ b/addons/web/static/src/js/core/misc.js @@ -2,9 +2,9 @@ odoo.define('web.framework', function (require) { "use strict"; var core = require('web.core'); -var crash_manager = require('web.crash_manager'); var ajax = require('web.ajax'); var Widget = require('web.Widget'); +var disableCrashManager = require('web.CrashManager').disable; var _t = core._t; @@ -101,7 +101,7 @@ function unblockUI() { */ function redirect (url, wait) { // Dont display a dialog if some xmlhttprequest are in progress - crash_manager.disable(); + disableCrashManager(); var load = function() { var old = "" + window.location; |
