diff options
| author | Géry Debongnie <ged@odoo.com> | 2018-04-11 10:36:25 +0200 |
|---|---|---|
| committer | Géry Debongnie <ged@odoo.com> | 2018-04-11 11:51:49 +0200 |
| commit | 86897ca167338ca434e62827fa09f44ddbce324c (patch) | |
| tree | ec00472e2fc0309c34e8cd6129deeaae85cfeb49 /addons/web/static/src/js/core/widget.js | |
| parent | f39b1bb4467e5c0da7d2b52cf69e27175d1247a9 (diff) | |
[REF] web: remove updateModifiersValue from widget
The keyboard shortcut branch recently added a method
updateModifiersValue on the widget class, which is used to make a widget
aware of its modifier status (in particular, if it is required). This
is necessary for the proper navigation behaviour on field widgets, but
should not be on the widget class.
The proper fix is, in my opinion, to introduce a AbstractViewWidget
class which would be used for AbstractField and all custom widgets in
views.
Meanwhile, this commit simply protects the call to that method. This is a
refactoring, but can be merged in saas-11.3.
Diffstat (limited to 'addons/web/static/src/js/core/widget.js')
| -rw-r--r-- | addons/web/static/src/js/core/widget.js | 10 |
1 files changed, 0 insertions, 10 deletions
diff --git a/addons/web/static/src/js/core/widget.js b/addons/web/static/src/js/core/widget.js index bd868596546..5e23c3f2c47 100644 --- a/addons/web/static/src/js/core/widget.js +++ b/addons/web/static/src/js/core/widget.js @@ -284,16 +284,6 @@ var Widget = core.Class.extend(mixins.PropertiesMixin, ServicesMixin, { return this; }, - - /** - * Update the modifiers with the newest value. - * Now this.attrs.modifiersValue can be used consistantly even with - * conditional modifiers - * - * @param {Object} modifiers the updated modifiers - */ - updateModifiersValue: function(modifiers) { - }, //-------------------------------------------------------------------------- // Private |