[REF] web: force dropdown menu icon through getter

Before this ref, the dropdown menu got his icon directly from his props.
This means that any inheriting class had either to define its icon with
the 'default_props' key or to have its parent giving it in the props.

Now, the icon is retrieved from the props via a getter (same as title
and items) and can be overridden to force a fixed icon on the class.

1 files changed, 9 insertions, 5 deletions

diff --git a/addons/web/static/src/js/control_panel/groupby_menu.js b/addons/web/static/src/js/control_panel/groupby_menu.js
index 858f2a7953e..97bad1a2ce7 100644
--- a/addons/web/static/src/js/control_panel/groupby_menu.js
+++ b/addons/web/static/src/js/control_panel/groupby_menu.js
@@ -1,9 +1,9 @@
 odoo.define('web.GroupByMenu', function (require) {
     "use strict";
 
-    const { GROUPABLE_TYPES } = require('web.searchUtils');
-    const DropdownMenu = require('web.DropdownMenu');
     const CustomGroupByItem = require('web.CustomGroupByItem');
+    const DropdownMenu = require('web.DropdownMenu');
+    const { FACET_ICONS, GROUPABLE_TYPES } = require('web.searchUtils');
     const { useModel } = require('web.model');
 
     /**
@@ -34,6 +34,13 @@ odoo.define('web.GroupByMenu', function (require) {
         /**
          * @override
          */
+        get icon() {
+            return FACET_ICONS.groupBy;
+        }
+
+        /**
+         * @override
+         */
         get items() {
             return this.model.getFiltersOfType('groupBy');
         }
@@ -82,9 +89,6 @@ odoo.define('web.GroupByMenu', function (require) {
     GroupByMenu.components = Object.assign({}, DropdownMenu.components, {
         CustomGroupByItem,
     });
-    GroupByMenu.defaultProps = Object.assign({}, DropdownMenu.defaultProps, {
-        icon: 'fa fa-bars',
-    });
     GroupByMenu.props = Object.assign({}, DropdownMenu.props, {
         fields: Object,
     });