[REF] Web: Actions, ActionManager, ViewManager, Controlpanel refactoring

Big refactoring of Action, WidgetAction and ViewManagerAction to clean
their API. Mainly, renamming from State to Action and removal of unused
functions (or functions that are only used by the DebugManager, for
which we tolerate introspection).

Some logic has also been moved from the ActionManager to the Actions
themselves. The specific behavior of each type of Action is now handled
in the implementation of those Actions.

In ActionManager, this.states is renammed to this.action_stack to be
consistent with view_stack in ViewManager.

The setup_search_view() and render_switch_buttons() functions have been
moved from ControlPanel to ViewManager as it was before, since actual
design allows it and it makes more sense.

The ControlPanel API has also been simplified as some functions were not
used anymore. The ControlPanel is now updated directly by the widgets
using it, bypassing the ActionManager. The control panel elements are
stored by the widgets themselves to allow restoring them later.

1 files changed, 12 insertions, 120 deletions

diff --git a/addons/web/static/src/js/control_panel.js b/addons/web/static/src/js/control_panel.js
index 768f7179511..2064ada44b9 100644
--- a/addons/web/static/src/js/control_panel.js
+++ b/addons/web/static/src/js/control_panel.js
@@ -2,16 +2,10 @@ odoo.define('web.ControlPanel', function (require) {
 "use strict";
 
 var core = require('web.core');
-var SearchView = require('web.SearchView');
 var Widget = require('web.Widget');
 
-var QWeb = core.qweb;
-
 var ControlPanel = Widget.extend({
     template: 'ControlPanel',
-    events: {
-        "click .oe-cp-switch-buttons button": "on_switch_buttons_click",
-    },
     /**
      * @param {String} [template] the QWeb template to render the ControlPanel.
      * By default, the template 'ControlPanel' will be used
@@ -23,13 +17,8 @@ var ControlPanel = Widget.extend({
         }
 
         this.bus = new core.Bus();
-        this.bus.on("setup_search_view", this, this.setup_search_view);
-        this.bus.on("render_switch_buttons", this, this.render_switch_buttons);
         this.bus.on("update", this, this.update);
         this.bus.on("update_breadcrumbs", this, this.update_breadcrumbs);
-
-        this.state = null;
-        this.searchview = null;
     },
     start: function() {
         // Retrieve ControlPanel jQuery nodes
@@ -55,36 +44,6 @@ var ControlPanel = Widget.extend({
         return this.bus;
     },
     /**
-     * @return {Object} the current State of the ControlPanel
-     */
-    get_state: function() {
-        return this.state;
-    },
-    /**
-     * Sets the state of the controlpanel (in the case of a viewmanager, set_state must be
-     * called before switch_mode for the controlpanel and the viewmanager to be synchronized)
-     * @param {Object} [state] the new state
-     */
-    set_state: function(state) {
-        this.state = state;
-        // Set the new state searchview
-        this.searchview = state.get_searchview();
-    },
-    /**
-     * Returns the content of the ControlPanel without detaching anything from it
-     * @return {Object} dictionnary containing the detached jQuery elements
-     */
-    get_content: function() {
-        return {
-            '$buttons': this.$buttons.contents(),
-            '$switch_buttons': this.$switch_buttons.contents(),
-            '$pager': this.$pager.contents(),
-            '$sidebar': this.$sidebar.contents(),
-            '$searchview': this.$searchview.contents(),
-            '$searchview_buttons': this.$searchview_buttons.contents(),
-        };
-    },
-    /**
      * Hides (or shows) the ControlPanel in headless (resp. non-headless) mode
      * Also detaches or attaches its contents to clean the DOM
      */
@@ -99,15 +58,14 @@ var ControlPanel = Widget.extend({
     },
     /**
      * Detaches the content of the ControlPanel
-     * @return {Object} dictionnary containing the detached jQuery elements
      */
     _detach_content: function() {
-        var cp_content = this.get_content();
-        _.each(cp_content, function($content) {
-            $content.detach();
-        });
-
-        return cp_content;
+        this.$buttons.contents().detach();
+        this.$switch_buttons.contents().detach();
+        this.$pager.contents().detach();
+        this.$sidebar.contents().detach();
+        this.$searchview.contents().detach();
+        this.$searchview_buttons.contents().detach();
     },
     /**
      * Attaches content to the ControlPanel
@@ -139,50 +97,20 @@ var ControlPanel = Widget.extend({
             // again in the ControlPanel will removed them from there they should be
             this._detach_content();
             this._attach_content(status.cp_content);
-            if (status.active_view) this.update_switch_buttons(status.active_view);
+            if (status.active_view_selector) this.update_switch_buttons(status.active_view_selector);
             if (status.searchview) this.update_search_view(status.searchview, status.search_view_hidden);
             if (status.breadcrumbs) this.update_breadcrumbs(status.breadcrumbs);
         }
     },
     /**
-     * Renders the switch buttons and call set_switch_buttons on the src
-     * Does not append the switch buttons to the DOM
-     * @param {Object} [src] the source requesting the switch_buttons
-     * @param {Array} [views] the array of views
-     */
-    render_switch_buttons: function(src, views) {
-        if (views.length > 1) {
-            var self = this;
-
-            // Render switch buttons but do not append them to the DOM as this will
-            // be done later, simultaneously to all other ControlPanel elements
-            var $switch_buttons = $(QWeb.render('ControlPanel.switch-buttons', {views: views}));
-
-            // Create bootstrap tooltips
-            _.each(views, function(view) {
-                self.$('.oe-cp-switch-' + view.type).tooltip();
-            });
-        }
-
-        // Set the buttons jQuery elements in the Widget which made the request
-        src.set_switch_buttons($switch_buttons);
-    },
-    /**
-     * Triggers an event when switch-buttons are clicked on
-     */
-    on_switch_buttons_click: function(event) {
-        var view_type = $(event.target).data('view-type');
-        this.trigger('switch_view', view_type);
-    },
-    /**
      * Removes active class on all switch-buttons and adds it to the one of the active view
-     * @param {Object} [active_view] the active_view
+     * @param {Object} [active_view_selector] the selector of the div to activate
      */
-    update_switch_buttons: function(active_view) {
-        _.each(this.$switch_buttons.contents('button'), function(button) {
+    update_switch_buttons: function(active_view_selector) {
+        _.each(this.$switch_buttons.find('button'), function(button) {
             $(button).removeClass('active');
         });
-        this.$('.oe-cp-switch-' + active_view.type).addClass('active');
+        this.$(active_view_selector).addClass('active');
     },
     /**
      * Updates the breadcrumbs
@@ -206,49 +134,13 @@ var ControlPanel = Widget.extend({
                     .toggleClass('active', is_last);
             if (!is_last) {
                 $bc.click(function () {
-                    self.trigger("on_breadcrumb_click", bc.widget, bc.index);
+                    self.trigger("on_breadcrumb_click", bc.action, bc.index);
                 });
             }
             return $bc;
         }
     },
     /**
-     * Sets up the search view and calls set_search_view on the widget requesting it
-     *
-     * @param {Object} [src] the widget requesting a search_view
-     * @param {Object} [action] the action (required to instantiated the SearchView)
-     * @param {Object} [dataset] the dataset (required to instantiated the SearchView)
-     * @param {Object} [flags] a dictionnary of Booleans
-     */
-    setup_search_view: function(src, action, dataset, flags) {
-        var view_id = (action && action.search_view_id && action.search_view_id[0]) || false;
-
-        var search_defaults = {};
-
-        var context = action ? action.context : [];
-        _.each(context, function (value, key) {
-            var match = /^search_default_(.*)$/.exec(key);
-            if (match) {
-                search_defaults[match[1]] = value;
-            }
-        });
-
-        var options = {
-            hidden: flags.search_view === false,
-            disable_custom_filters: flags.search_disable_custom_filters,
-            $buttons: $("<div>"),
-            action: action,
-        };
-
-        // Instantiate the SearchView, but do not append it nor its buttons to the DOM as this will
-        // be done later, simultaneously to all other ControlPanel elements
-        var searchview = new SearchView(this, dataset, view_id, search_defaults, options);
-        searchview.appendTo($("<div>")).then(function() {
-            // Set the SearchView in the widget which made the request
-            src.set_search_view(searchview);
-        });
-    },
-    /**
      * Updates the SearchView's visibility and extend the breadcrumbs area if the SearchView is not visible
      * @param {openerp.web.SearchView} [searchview] the searchview Widget
      * @param {Boolean} [is_hidden] visibility of the searchview