summaryrefslogtreecommitdiff
path: root/addons/web/static/lib/jquery.mjs.nestedSortable/jquery.mjs.nestedSortable.js
diff options
context:
space:
mode:
authorqsm-odoo <qsm@odoo.com>2017-12-14 12:45:39 +0100
committerqsm-odoo <qsm@odoo.com>2017-12-15 14:06:04 +0100
commit69d4383d7bcc52cf69628ec029bfffff387b04ea (patch)
tree4282b28011330457bbe6c6d7ce779d4f548f1a96 /addons/web/static/lib/jquery.mjs.nestedSortable/jquery.mjs.nestedSortable.js
parentc8df0333f5aca04d2923c34f4efa9d79b50d4a3f (diff)
[FIX] web_editor: browser-unify alignment editor option
Summernote uses `document.execCommand` to apply most styles when editing, leveraging the implementation to the browser. Summernote is configured to use HTML styling (`'styleWithSpan': false`), and in this case, browsers such as Firefox use HTML attributes for styling text align, while Chrome still uses CSS for that. In fact, `document.execCommand` is browser-inconsistent... but so is the `styleWithSpan` option. Indeed, setting the option to `true` will make Firefox use CSS property for alignment too... but not Internet Explorer. So we might consider changing this option's value but this would not solve the current problem. Indeed, any CSS `text-align` style in Firefox takes precedence above the element's `align` attribute, so when users were trying to align text on stuff that was pre-aligned, they were unable to do so. We can better explain the situation with this example: A user tries to left-align in Firefox a `p.text-center` element, and produces this: ```html <p class="text-center" align="left"/> ``` (`align` attribute is ignored because of the `text-center` class) On Chrome, this would be produced with the same steps: ```html <p class="text-center" style="text-align:left"/> ``` With this patch, we actually make that HTML look like expected by the user, no matter the browser he's using, by forcing the editor to use the text-align CSS property. Note that the implementation is quite ugly but had to take care of compatibility. See https://github.com/odoo/odoo/pull/20900 (thanks to @Yajo for original PR)
Diffstat (limited to 'addons/web/static/lib/jquery.mjs.nestedSortable/jquery.mjs.nestedSortable.js')
0 files changed, 0 insertions, 0 deletions