diff options
| author | Julien Castiaux <juc@odoo.com> | 2019-09-09 16:10:13 +0000 |
|---|---|---|
| committer | Xavier Morel <xmo@odoo.com> | 2019-09-20 05:58:16 +0000 |
| commit | d47083e6d219bdd2ca0e36a41aef5274f67a70f1 (patch) | |
| tree | 14328a15f2a713c7de7e756c28ce1f28e0e7b6f5 /addons/web/controllers | |
| parent | 18299d7e5051cdad29854bc7280db5002a209500 (diff) | |
[IMP] module.py: deprecate openerp
[PEP-594] is deprecating the `imp` module, that module is used in
`module.py` in order to dynamically import addons using any of the
`odoo.addons` or `openerp.addons` import anchor.
We are deprecating `openerp` module/addons imports in v13 in order to
remove the support in v14 and greatly simplify how modules/addons are
loaded. If you are still using the old `import openerp` or `import
openerp.addons`, `import odoo` and `import odoo.addons` are drop-in
replacements.
The `odoo.modules.module.ad_paths` addon paths list has been deprecated
too. The list is now accessible on `odoo.addons.__path__` where they
are now directly loaded [2].
See also:
[PEP-594]: https://python.org/dev/peps/pep-0594/
[2]: https://packaging.python.org/guides/packaging-namespace-packages/
closes odoo/odoo#36597
Task: 2003936
Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
Diffstat (limited to 'addons/web/controllers')
| -rw-r--r-- | addons/web/controllers/main.py | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/addons/web/controllers/main.py b/addons/web/controllers/main.py index d893271ac6c..40f351e7f78 100644 --- a/addons/web/controllers/main.py +++ b/addons/web/controllers/main.py @@ -1155,7 +1155,8 @@ class View(http.Controller): class Binary(http.Controller): def placeholder(self, image='placeholder.png'): - return tools.file_open(get_resource_path('web', 'static/src/img', image), 'rb').read() + with tools.file_open(get_resource_path('web', 'static/src/img', image), 'rb') as fd: + return fd.read() @http.route(['/web/content', '/web/content/<string:xmlid>', |