summaryrefslogtreecommitdiff
path: root/addons/web/controllers/main.py
diff options
context:
space:
mode:
authorNicolas Lempereur <nle@odoo.com>2019-01-24 15:59:20 +0000
committerNicolas Lempereur <nle@odoo.com>2019-01-24 16:18:19 +0000
commitce6e66cef930a30d9a62988a16f9f8319cb9f25c (patch)
treedbaa3d49b1954017f2e51caa6313e84428c883b5 /addons/web/controllers/main.py
parentb42cd64ace5f859184b8cc47a0db0963c03ae73b (diff)
[FIX] web: bar chart no crazy with 2 group by
In 3d2ca8104e4 some change were introduced to the graph view. But part of it had no sense when displaying data over 2 group by. eg. if the first level has 2 groups (2018, 2019) and each second level 2 groups (Done,Cancelled), we could have: 2018/Done: 0 2018/Cancelled: 5 2019/Done: 8 2019/Cancelled: 9 this gives us two main groups [2018: 5] / [2019: 17], the code remove the 2018 because [2018/Done] is 0 so we have something odd with columns not in order, and in stacked bar chart some part of a bar at the wrong offset opw-1932517 closes #30529
Diffstat (limited to 'addons/web/controllers/main.py')
-rw-r--r--addons/web/controllers/main.py23
1 files changed, 10 insertions, 13 deletions
diff --git a/addons/web/controllers/main.py b/addons/web/controllers/main.py
index d83e4f36f88..74c936ed73b 100644
--- a/addons/web/controllers/main.py
+++ b/addons/web/controllers/main.py
@@ -1088,10 +1088,17 @@ class Binary(http.Controller):
height = int(height or 0)
width = int(width or 0)
+ if not content:
+ content = base64.b64encode(self.placeholder(image='placeholder.png'))
+ headers = self.force_contenttype(headers, contenttype='image/png')
+ if not (width or height):
+ suffix = field.split('_')[-1]
+ if suffix in ('small', 'medium', 'big'):
+ content = getattr(odoo.tools, 'image_resize_image_%s' % suffix)(content)
+
if crop and (width or height):
content = crop_image(content, type='center', size=(width, height), ratio=(1, 1))
-
- elif content and (width or height):
+ elif (width or height):
if not upper_limit:
# resize maximum 500*500
if width > 500:
@@ -1102,17 +1109,7 @@ class Binary(http.Controller):
encoding='base64', upper_limit=upper_limit,
avoid_if_small=avoid_if_small)
- if content:
- image_base64 = base64.b64decode(content)
- else:
- suffix = field.split('_')[-1]
- if suffix in ('small', 'medium', 'big'):
- encoded_placeholder = base64.b64encode(self.placeholder(image='placeholder.png'))
- image_base64 = base64.b64decode(getattr(odoo.tools, 'image_resize_image_%s' % suffix)(encoded_placeholder))
- else:
- image_base64 = self.placeholder(image='placeholder.png') # could return (contenttype, content) in master
- headers = self.force_contenttype(headers, contenttype='image/png')
-
+ image_base64 = base64.b64decode(content)
headers.append(('Content-Length', len(image_base64)))
response = request.make_response(image_base64, headers)
response.status_code = status