[REF] test_mass_mailing: update module to new common

PURPOSE

Currently tools and asserts for mail tests are located inside test_mail
module. It makes difficult to re-use them in apps tests or force them to
write custom quick and dirty tools and asserts.

SPECIFICATIONS

Update this module to new tools / asserts / helpers / classes defined in mail
and test_mail.

In this commit we remove the ``MassMailingCase`` and replace it by a fresh
``TestMailCommon`` that is simply updated to hold a marketing user by default.
That way all mocks and asserts are available in all sub test classes.

Coming from common update, we have notably

  * ``BaseFunctionalTest`` class is replaced by the new ``TestMailCommon``
    pimped one;
  * ``assertNotifications`` is replaced by ``assertSinglePostNotifications``
    (shortcut for a simple message_post) or ``assertPostNotifications``
    (complete asserts involving several messages and notifications);
  * correctly invoke ``mock_mail_gateway`` when mocking email sending;
  * replace manual check of sent emails or ``assertEmails`` by
    ``assertSentEmails``;
  * remove custom mocks / checks and replace them by now standard mocks
    and assertions (if any);

LINKS

Task ID 2068986
PR #38070

1 files changed, 4 insertions, 11 deletions

diff --git a/addons/test_mass_mailing/tests/common.py b/addons/test_mass_mailing/tests/common.py
index b0a7e3985d6..c66b92906b0 100644
--- a/addons/test_mass_mailing/tests/common.py
+++ b/addons/test_mass_mailing/tests/common.py
@@ -1,24 +1,17 @@
 # -*- coding: utf-8 -*-
 # Part of Odoo. See LICENSE file for full copyright and licensing details.
 
+from odoo.addons.mail.tests.common import mail_new_test_user
 from odoo.addons.test_mail.tests import common
-from odoo.addons.test_mail.tests.common import mail_new_test_user
-from odoo.tests import tagged
 
 
-@tagged('mass_mail')
-class MassMailingCase(common.MockEmails, common.BaseFunctionalTest):
+class TestMailCommon(common.TestMailCommon):
 
     @classmethod
     def setUpClass(cls):
-        super(MassMailingCase, cls).setUpClass()
-
-        # be sure for some common data
-        cls.user_employee.write({
-            'login': 'emp',
-        })
+        super(TestMailCommon, cls).setUpClass()
 
         cls.user_marketing = mail_new_test_user(
             cls.env, login='marketing',
-            groups='base.group_user,mass_mailing.group_mass_mailing_user',
+            groups='base.group_user,base.group_partner_manager,mass_mailing.group_mass_mailing_user',
             name='Martial Marketing', signature='--\nMartial')