[FIX] *: sudo() -> with_user()

6 files changed, 46 insertions, 46 deletions

diff --git a/addons/survey/tests/common.py b/addons/survey/tests/common.py
index 71af5d8d4d0..def5c81e2bb 100644
--- a/addons/survey/tests/common.py
+++ b/addons/survey/tests/common.py
@@ -63,26 +63,26 @@ class SurveyCase(common.SavepointCase):
             'customer': True,
         })
 
-        self.survey = self.env['survey.survey'].sudo(self.survey_manager).create({
+        self.survey = self.env['survey.survey'].with_user(self.survey_manager).create({
             'title': 'Test Survey',
             'access_mode': 'public',
             'users_login_required': True,
             'users_can_go_back': False,
             'state': 'open',
         })
-        self.page_0 = self.env['survey.question'].sudo(self.survey_manager).create({
+        self.page_0 = self.env['survey.question'].with_user(self.survey_manager).create({
             'title': 'First page',
             'survey_id': self.survey.id,
             'sequence': 1,
             'is_page': True,
         })
-        self.question_ft = self.env['survey.question'].sudo(self.survey_manager).create({
+        self.question_ft = self.env['survey.question'].with_user(self.survey_manager).create({
             'title': 'Test Free Text',
             'survey_id': self.survey.id,
             'sequence': 2,
             'question_type': 'free_text',
         })
-        self.question_num = self.env['survey.question'].sudo(self.survey_manager).create({
+        self.question_num = self.env['survey.question'].with_user(self.survey_manager).create({
             'title': 'Test NUmerical Box',
             'survey_id': self.survey.id,
             'sequence': 3,
@@ -90,8 +90,8 @@ class SurveyCase(common.SavepointCase):
         })
 
     @contextmanager
-    def sudo(self, user):
-        """ Quick sudo environment """
+    def with_user(self, user):
+        """ Quick with_user environment """
         old_uid = self.uid
         try:
             self.uid = user.id
diff --git a/addons/survey/tests/test_certification_flow.py b/addons/survey/tests/test_certification_flow.py
index b1db33ec215..42e58af21b1 100644
--- a/addons/survey/tests/test_certification_flow.py
+++ b/addons/survey/tests/test_certification_flow.py
@@ -38,7 +38,7 @@ class TestCertificationFlow(common.SurveyCase, HttpCase):
     def test_flow_certificate(self):
         # Step: survey user creates the certification
         # --------------------------------------------------
-        with self.sudo(self.survey_user):
+        with self.with_user(self.survey_user):
             certification = self.env['survey.survey'].create({
                 'title': 'User Certification for SO lines',
                 'access_mode': 'public',
diff --git a/addons/survey/tests/test_survey_compute_pages_questions.py b/addons/survey/tests/test_survey_compute_pages_questions.py
index 3fd54cc00fa..0ab8ff567c1 100644
--- a/addons/survey/tests/test_survey_compute_pages_questions.py
+++ b/addons/survey/tests/test_survey_compute_pages_questions.py
@@ -6,7 +6,7 @@ from odoo.addons.survey.tests import common
 
 class TestSurveyComputePagesQuestions(common.SurveyCase):
     def test_compute_pages_questions(self):
-        with self.sudo(self.survey_manager):
+        with self.with_user(self.survey_manager):
             survey = self.env['survey.survey'].create({
                 'title': 'Test compute survey',
                 'state': 'open',
diff --git a/addons/survey/tests/test_survey_flow.py b/addons/survey/tests/test_survey_flow.py
index 35247902c76..a383a54430f 100644
--- a/addons/survey/tests/test_survey_flow.py
+++ b/addons/survey/tests/test_survey_flow.py
@@ -28,7 +28,7 @@ class TestSurveyFlow(common.SurveyCase, HttpCase):
     def test_flow_public(self):
         # Step: survey manager creates the survey
         # --------------------------------------------------
-        with self.sudo(self.survey_manager):
+        with self.with_user(self.survey_manager):
             survey = self.env['survey.survey'].create({
                 'title': 'Public Survey for Tarte Al Djotte',
                 'access_mode': 'public',
diff --git a/addons/survey/tests/test_survey_invite.py b/addons/survey/tests/test_survey_invite.py
index 4f5224e6872..bf99cc93089 100644
--- a/addons/survey/tests/test_survey_invite.py
+++ b/addons/survey/tests/test_survey_invite.py
@@ -32,7 +32,7 @@ class TestSurveyInvite(common.SurveyCase):
             # no questions
             self.env['survey.survey'].create({'title': 'Test survey', 'question_and_page_ids': [(0, 0, {'is_page': True, 'title': 'P0', 'sequence': 1})]}),
             # closed
-            self.env['survey.survey'].sudo(self.survey_manager).create({
+            self.env['survey.survey'].with_user(self.survey_manager).create({
                 'title': 'S0',
                 'state': 'closed',
                 'question_and_page_ids': [
diff --git a/addons/survey/tests/test_survey_security.py b/addons/survey/tests/test_survey_security.py
index b2473029f7a..42077ae6018 100644
--- a/addons/survey/tests/test_survey_security.py
+++ b/addons/survey/tests/test_survey_security.py
@@ -33,23 +33,23 @@ class TestAccess(common.SurveyCase):
         with self.assertRaises(AccessError):
             self.env['survey.survey'].search([('title', 'ilike', 'Test')])
         with self.assertRaises(AccessError):
-            self.survey.sudo(self.env.user).read(['title'])
+            self.survey.with_user(self.env.user).read(['title'])
 
         # Write: nope
         with self.assertRaises(AccessError):
-            self.survey.sudo(self.env.user).write({'title': 'New Title'})
+            self.survey.with_user(self.env.user).write({'title': 'New Title'})
         with self.assertRaises(AccessError):
-            self.page_0.sudo(self.env.user).write({'title': 'New Title'})
+            self.page_0.with_user(self.env.user).write({'title': 'New Title'})
         with self.assertRaises(AccessError):
-            self.question_ft.sudo(self.env.user).write({'question': 'New Title'})
+            self.question_ft.with_user(self.env.user).write({'question': 'New Title'})
 
         # Unlink: nope
         with self.assertRaises(AccessError):
-            self.survey.sudo(self.env.user).unlink()
+            self.survey.with_user(self.env.user).unlink()
         with self.assertRaises(AccessError):
-            self.page_0.sudo(self.env.user).unlink()
+            self.page_0.with_user(self.env.user).unlink()
         with self.assertRaises(AccessError):
-            self.question_ft.sudo(self.env.user).unlink()
+            self.question_ft.with_user(self.env.user).unlink()
 
     @mute_logger('odoo.addons.base.models.ir_model')
     @users('user_portal')
@@ -66,23 +66,23 @@ class TestAccess(common.SurveyCase):
         with self.assertRaises(AccessError):
             self.env['survey.survey'].search([('title', 'ilike', 'Test')])
         with self.assertRaises(AccessError):
-            self.survey.sudo(self.env.user).read(['title'])
+            self.survey.with_user(self.env.user).read(['title'])
 
         # Write: nope
         with self.assertRaises(AccessError):
-            self.survey.sudo(self.env.user).write({'title': 'New Title'})
+            self.survey.with_user(self.env.user).write({'title': 'New Title'})
         with self.assertRaises(AccessError):
-            self.page_0.sudo(self.env.user).write({'title': 'New Title'})
+            self.page_0.with_user(self.env.user).write({'title': 'New Title'})
         with self.assertRaises(AccessError):
-            self.question_ft.sudo(self.env.user).write({'question': 'New Title'})
+            self.question_ft.with_user(self.env.user).write({'question': 'New Title'})
 
         # Unlink: nope
         with self.assertRaises(AccessError):
-            self.survey.sudo(self.env.user).unlink()
+            self.survey.with_user(self.env.user).unlink()
         with self.assertRaises(AccessError):
-            self.page_0.sudo(self.env.user).unlink()
+            self.page_0.with_user(self.env.user).unlink()
         with self.assertRaises(AccessError):
-            self.question_ft.sudo(self.env.user).unlink()
+            self.question_ft.with_user(self.env.user).unlink()
 
     @mute_logger('odoo.addons.base.models.ir_model')
     @users('user_public')
@@ -99,23 +99,23 @@ class TestAccess(common.SurveyCase):
         with self.assertRaises(AccessError):
             self.env['survey.survey'].search([('title', 'ilike', 'Test')])
         with self.assertRaises(AccessError):
-            self.survey.sudo(self.env.user).read(['title'])
+            self.survey.with_user(self.env.user).read(['title'])
 
         # Write: nope
         with self.assertRaises(AccessError):
-            self.survey.sudo(self.env.user).write({'title': 'New Title'})
+            self.survey.with_user(self.env.user).write({'title': 'New Title'})
         with self.assertRaises(AccessError):
-            self.page_0.sudo(self.env.user).write({'title': 'New Title'})
+            self.page_0.with_user(self.env.user).write({'title': 'New Title'})
         with self.assertRaises(AccessError):
-            self.question_ft.sudo(self.env.user).write({'question': 'New Title'})
+            self.question_ft.with_user(self.env.user).write({'question': 'New Title'})
 
         # Unlink: nope
         with self.assertRaises(AccessError):
-            self.survey.sudo(self.env.user).unlink()
+            self.survey.with_user(self.env.user).unlink()
         with self.assertRaises(AccessError):
-            self.page_0.sudo(self.env.user).unlink()
+            self.page_0.with_user(self.env.user).unlink()
         with self.assertRaises(AccessError):
-            self.question_ft.sudo(self.env.user).unlink()
+            self.question_ft.with_user(self.env.user).unlink()
 
     @users('survey_manager')
     def test_access_survey_survey_manager(self):
@@ -151,12 +151,12 @@ class TestAccess(common.SurveyCase):
         # Write: own only
         survey.write({'title': 'New Title'})
         with self.assertRaises(AccessError):
-            self.survey.sudo(self.env.user).write({'title': 'New Title'})
+            self.survey.with_user(self.env.user).write({'title': 'New Title'})
 
         # Unlink: own only
         survey.unlink()
         with self.assertRaises(AccessError):
-            self.survey.sudo(self.env.user).unlink()
+            self.survey.with_user(self.env.user).unlink()
 
     @mute_logger('odoo.addons.base.models.ir_model')
     @users('user_emp')
@@ -179,13 +179,13 @@ class TestAccess(common.SurveyCase):
 
         # Write: nope
         with self.assertRaises(AccessError):
-            self.answer_0.sudo(self.env.user).write({'state': 'done'})
+            self.answer_0.with_user(self.env.user).write({'state': 'done'})
 
         # Unlink: nope
         with self.assertRaises(AccessError):
-            self.answer_0.sudo(self.env.user).unlink()
+            self.answer_0.with_user(self.env.user).unlink()
         with self.assertRaises(AccessError):
-            self.answer_0_0.sudo(self.env.user).unlink()
+            self.answer_0_0.with_user(self.env.user).unlink()
 
     @mute_logger('odoo.addons.base.models.ir_model')
     @users('user_portal')
@@ -208,13 +208,13 @@ class TestAccess(common.SurveyCase):
 
         # Write: nope
         with self.assertRaises(AccessError):
-            self.answer_0.sudo(self.env.user).write({'state': 'done'})
+            self.answer_0.with_user(self.env.user).write({'state': 'done'})
 
         # Unlink: nope
         with self.assertRaises(AccessError):
-            self.answer_0.sudo(self.env.user).unlink()
+            self.answer_0.with_user(self.env.user).unlink()
         with self.assertRaises(AccessError):
-            self.answer_0_0.sudo(self.env.user).unlink()
+            self.answer_0_0.with_user(self.env.user).unlink()
 
     @mute_logger('odoo.addons.base.models.ir_model')
     @users('user_public')
@@ -237,13 +237,13 @@ class TestAccess(common.SurveyCase):
 
         # Write: nope
         with self.assertRaises(AccessError):
-            self.answer_0.sudo(self.env.user).write({'state': 'done'})
+            self.answer_0.with_user(self.env.user).write({'state': 'done'})
 
         # Unlink: nope
         with self.assertRaises(AccessError):
-            self.answer_0.sudo(self.env.user).unlink()
+            self.answer_0.with_user(self.env.user).unlink()
         with self.assertRaises(AccessError):
-            self.answer_0_0.sudo(self.env.user).unlink()
+            self.answer_0_0.with_user(self.env.user).unlink()
 
     @mute_logger('odoo.addons.base.models.ir_model')
     @users('survey_user')
@@ -278,20 +278,20 @@ class TestAccess(common.SurveyCase):
         # Write: own survey only
         answer_own.write({'state': 'done'})
         with self.assertRaises(AccessError):
-            self.answer_0.sudo(self.env.user).write({'state': 'done'})
+            self.answer_0.with_user(self.env.user).write({'state': 'done'})
 
         # Unlink: own survey only
         answer_own.unlink()
         answer_line_own.unlink()
         with self.assertRaises(AccessError):
-            self.answer_0.sudo(self.env.user).unlink()
+            self.answer_0.with_user(self.env.user).unlink()
         with self.assertRaises(AccessError):
-            self.answer_0_0.sudo(self.env.user).unlink()
+            self.answer_0_0.with_user(self.env.user).unlink()
 
     @users('survey_manager')
     def test_access_answers_survey_manager(self):
         admin = self.env.ref('base.user_admin')
-        with self.sudo(admin):
+        with self.with_user(admin):
             survey_other = self.env['survey.survey'].create({'title': 'Other'})
             self.env['survey.question'].create({'title': 'Other', 'sequence': 0, 'is_page': True, 'survey_id': survey_other.id})
             question_other = self.env['survey.question'].create({'title': 'Other Question', 'sequence': 1, 'survey_id': survey_other.id})