diff options
| author | mreficent <miquel.raich@eficent.com> | 2020-02-19 12:42:23 +0000 |
|---|---|---|
| committer | Martin Trigaux <mat@odoo.com> | 2020-02-20 14:58:33 +0000 |
| commit | 3dffce34bf80c2a8d8682ef986d6daafa5bb0b7f (patch) | |
| tree | 3ec174f7aa3d672d07635d4f54401ff3d7fa3725 /addons/stock | |
| parent | 62c9227fdaac43329e48cd9446b40eee60dfeb1c (diff) | |
[IMP] fields: log warning for ignored selection
When a field is related, defining a selection or selection_add will
have no effect and the paramater is ignored.
Log a warning and fix all fields badly definied
Closes odoo/odoo#45716
closes odoo/odoo#45832
Related: odoo/enterprise#8613
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
Diffstat (limited to 'addons/stock')
| -rw-r--r-- | addons/stock/models/stock_inventory.py | 4 | ||||
| -rw-r--r-- | addons/stock/models/stock_picking.py | 6 | ||||
| -rw-r--r-- | addons/stock/models/stock_scrap.py | 2 |
3 files changed, 5 insertions, 7 deletions
diff --git a/addons/stock/models/stock_inventory.py b/addons/stock/models/stock_inventory.py index 2f6e3f045fa..056fa55778e 100644 --- a/addons/stock/models/stock_inventory.py +++ b/addons/stock/models/stock_inventory.py @@ -357,7 +357,7 @@ class InventoryLine(models.Model): company_id = fields.Many2one( 'res.company', 'Company', related='inventory_id.company_id', index=True, readonly=True, store=True) - state = fields.Selection('Status', related='inventory_id.state') + state = fields.Selection(string='Status', related='inventory_id.state') theoretical_qty = fields.Float( 'Theoretical Quantity', digits='Product Unit of Measure', readonly=True) @@ -369,7 +369,7 @@ class InventoryLine(models.Model): help="Last date at which the On Hand Quantity has been computed.") outdated = fields.Boolean(string='Quantity outdated', compute='_compute_outdated', search='_search_outdated') - product_tracking = fields.Selection('Tracking', related='product_id.tracking', readonly=True) + product_tracking = fields.Selection(string='Tracking', related='product_id.tracking', readonly=True) @api.depends('product_qty', 'theoretical_qty') def _compute_difference(self): diff --git a/addons/stock/models/stock_picking.py b/addons/stock/models/stock_picking.py index b18920d4435..3fb316194db 100644 --- a/addons/stock/models/stock_picking.py +++ b/addons/stock/models/stock_picking.py @@ -315,10 +315,8 @@ class Picking(models.Model): 'stock.picking.type', 'Operation Type', required=True, readonly=True, states={'draft': [('readonly', False)]}) - picking_type_code = fields.Selection([ - ('incoming', 'Vendors'), - ('outgoing', 'Customers'), - ('internal', 'Internal')], related='picking_type_id.code', + picking_type_code = fields.Selection( + related='picking_type_id.code', readonly=True) picking_type_entire_packs = fields.Boolean(related='picking_type_id.show_entire_packs', readonly=True) diff --git a/addons/stock/models/stock_scrap.py b/addons/stock/models/stock_scrap.py index ea7c5f4c9da..e2c80ac8970 100644 --- a/addons/stock/models/stock_scrap.py +++ b/addons/stock/models/stock_scrap.py @@ -36,7 +36,7 @@ class StockScrap(models.Model): 'uom.uom', 'Unit of Measure', required=True, states={'done': [('readonly', True)]}, domain="[('category_id', '=', product_uom_category_id)]") product_uom_category_id = fields.Many2one(related='product_id.uom_id.category_id') - tracking = fields.Selection('Product Tracking', readonly=True, related="product_id.tracking") + tracking = fields.Selection(string='Product Tracking', readonly=True, related="product_id.tracking") lot_id = fields.Many2one( 'stock.production.lot', 'Lot/Serial', states={'done': [('readonly', True)]}, domain="[('product_id', '=', product_id), ('company_id', '=', company_id)]", check_company=True) |