summaryrefslogtreecommitdiff
path: root/addons/snailmail
diff options
context:
space:
mode:
authorAdrian Torres <adt@odoo.com>2019-07-10 14:59:37 +0200
committerAdrian Torres <adt@odoo.com>2019-07-17 14:13:12 +0200
commit4b38cc6590abcb58a0ca102a06063eb3db7ac1f4 (patch)
treecfd11739fc6b4c0cb4b23b54cc6badad4bf5c55e /addons/snailmail
parentf6fdde96bddfedf8764cd8a73089e44340d476ae (diff)
[REM] *: calls to @api.multi
Multi is the default api for methods, it is not necessary to explicitly decorate methods with it, adds clutter and most people use it because they see that the rest of the code uses it. Done with `find . -type f -name '*.py' | xargs sed -i '/@api.multi/d'`
Diffstat (limited to 'addons/snailmail')
-rw-r--r--addons/snailmail/models/ir_actions_report.py1
-rw-r--r--addons/snailmail/models/mail_message.py6
-rw-r--r--addons/snailmail/models/res_partner.py2
-rw-r--r--addons/snailmail/models/snailmail_letter.py9
-rw-r--r--addons/snailmail/wizard/snailmail_letter_cancel.py2
-rw-r--r--addons/snailmail/wizard/snailmail_letter_format_error.py2
-rw-r--r--addons/snailmail/wizard/snailmail_letter_missing_required_fields.py2
7 files changed, 0 insertions, 24 deletions
diff --git a/addons/snailmail/models/ir_actions_report.py b/addons/snailmail/models/ir_actions_report.py
index b441d55c0fb..91573ef4d7f 100644
--- a/addons/snailmail/models/ir_actions_report.py
+++ b/addons/snailmail/models/ir_actions_report.py
@@ -6,7 +6,6 @@ from odoo import models, fields, api, _
class IrActionsReport(models.Model):
_inherit = 'ir.actions.report'
- @api.multi
def retrieve_attachment(self, record):
# Override this method in order to force to re-render the pdf in case of
# using snailmail
diff --git a/addons/snailmail/models/mail_message.py b/addons/snailmail/models/mail_message.py
index f649455ca70..38364f75590 100644
--- a/addons/snailmail/models/mail_message.py
+++ b/addons/snailmail/models/mail_message.py
@@ -9,14 +9,12 @@ class Message(models.Model):
letter_ids = fields.One2many(comodel_name='snailmail.letter', inverse_name='message_id')
message_type = fields.Selection(selection_add=[('snailmail', 'Snailmail')])
- @api.multi
def _get_message_format_fields(self):
res = super(Message, self)._get_message_format_fields()
res.append('snailmail_error')
res.append('snailmail_status')
return res
- @api.multi
@api.depends('letter_ids', 'letter_ids.state')
def _compute_snailmail_error(self):
for message in self:
@@ -27,21 +25,17 @@ class Message(models.Model):
message.snailmail_error = False
message.snailmail_status = ''
- @api.multi
def _search_snailmail_error(self, operator, operand):
if operator == '=' and operand:
return ['&', ('letter_ids.state', '=', 'error'), ('letter_ids.user_id', '=', self.env.user.id)]
return ['!', '&', ('letter_ids.state', '=', 'error'), ('letter_ids.user_id', '=', self.env.user.id)]
- @api.multi
def cancel_letter(self):
self.mapped('letter_ids').cancel()
- @api.multi
def send_letter(self):
self.mapped('letter_ids')._snailmail_print()
- @api.multi
def message_fetch_failed(self):
res = super(Message, self).message_fetch_failed()
failed_letters = self.letter_ids.fetch_failed_letters()
diff --git a/addons/snailmail/models/res_partner.py b/addons/snailmail/models/res_partner.py
index c4b3b576bf0..ce105b3685f 100644
--- a/addons/snailmail/models/res_partner.py
+++ b/addons/snailmail/models/res_partner.py
@@ -9,7 +9,6 @@ from odoo.addons.snailmail.country_utils import SNAILMAIL_COUNTRIES
class ResPartner(models.Model):
_inherit = "res.partner"
- @api.multi
def write(self, vals):
letter_address_vals = {}
address_fields = ['street', 'street2', 'city', 'zip', 'state_id', 'country_id']
@@ -23,7 +22,6 @@ class ResPartner(models.Model):
return super(ResPartner, self).write(vals)
- @api.multi
def _get_country_name(self):
# when sending a letter, thus rendering the report with the snailmail_layout,
# we need to override the country name to its english version following the
diff --git a/addons/snailmail/models/snailmail_letter.py b/addons/snailmail/models/snailmail_letter.py
index b9e2fb55477..96b1a91e4c4 100644
--- a/addons/snailmail/models/snailmail_letter.py
+++ b/addons/snailmail/models/snailmail_letter.py
@@ -95,7 +95,6 @@ class SnailmailLetter(models.Model):
})
return super(SnailmailLetter, self).create(vals)
- @api.multi
def _fetch_attachment(self):
"""
This method will check if we have any existent attachement matching the model
@@ -141,7 +140,6 @@ class SnailmailLetter(models.Model):
pages = int(match.group(1))
return pages
- @api.multi
def _snailmail_create(self, route):
"""
Create a dictionnary object to send to snailmail server.
@@ -271,7 +269,6 @@ class SnailmailLetter(models.Model):
return _('An unknown error happened. Please contact the support.')
return error
- @api.multi
def _snailmail_print(self, immediate=True):
valid_address_letters = self.filtered(lambda l: l._is_valid_address(l))
invalid_address_letters = self - valid_address_letters
@@ -280,7 +277,6 @@ class SnailmailLetter(models.Model):
valid_address_letters._snailmail_print_valid_address()
self.env.cr.commit()
- @api.multi
def _snailmail_print_invalid_address(self):
for letter in self:
letter.write({
@@ -290,7 +286,6 @@ class SnailmailLetter(models.Model):
})
self.send_snailmail_update()
- @api.multi
def _snailmail_print_valid_address(self):
"""
get response
@@ -326,7 +321,6 @@ class SnailmailLetter(models.Model):
letter.write(letter_data)
self.send_snailmail_update()
- @api.multi
def send_snailmail_update(self):
notifications = []
for letter in self:
@@ -336,11 +330,9 @@ class SnailmailLetter(models.Model):
])
self.env['bus.bus'].sendmany(notifications)
- @api.multi
def snailmail_print(self):
self._snailmail_print()
- @api.multi
def cancel(self):
self.write({'state': 'canceled', 'error_code': False})
self.send_snailmail_update()
@@ -367,7 +359,6 @@ class SnailmailLetter(models.Model):
required_keys = ['street', 'city', 'zip', 'country_id']
return all(record[key] for key in required_keys)
- @api.multi
def _format_snailmail_failures(self):
"""
A shorter message to notify a failure update
diff --git a/addons/snailmail/wizard/snailmail_letter_cancel.py b/addons/snailmail/wizard/snailmail_letter_cancel.py
index 3cb5aa1621c..d27eb801314 100644
--- a/addons/snailmail/wizard/snailmail_letter_cancel.py
+++ b/addons/snailmail/wizard/snailmail_letter_cancel.py
@@ -8,13 +8,11 @@ class SnailmailLetterCancel(models.TransientModel):
model = fields.Char(string='Model')
help_message = fields.Char(string='Help message', compute='_compute_help_message')
- @api.multi
@api.depends('model')
def _compute_help_message(self):
for wizard in self:
wizard.help_message = _("Are you sure you want to discard %s snailmail delivery failures. You won't be able to re-send these letters later!") % (wizard._context.get('unread_counter'))
- @api.multi
def cancel_resend_action(self):
author_id = self.env.user.id
for wizard in self:
diff --git a/addons/snailmail/wizard/snailmail_letter_format_error.py b/addons/snailmail/wizard/snailmail_letter_format_error.py
index 0f830dd4ce6..d8b6c06bd69 100644
--- a/addons/snailmail/wizard/snailmail_letter_format_error.py
+++ b/addons/snailmail/wizard/snailmail_letter_format_error.py
@@ -18,7 +18,6 @@ class SnailmailLetterFormatError(models.TransientModel):
})
return res
- @api.multi
def update_resend_action(self):
self.env.company.write({'snailmail_cover': self.snailmail_cover})
letters_to_resend = self.env['snailmail.letter'].search([
@@ -29,6 +28,5 @@ class SnailmailLetterFormatError(models.TransientModel):
letter.write({'cover': self.snailmail_cover})
letter.snailmail_print()
- @api.multi
def cancel_letter_action(self):
self.message_id.cancel_letter()
diff --git a/addons/snailmail/wizard/snailmail_letter_missing_required_fields.py b/addons/snailmail/wizard/snailmail_letter_missing_required_fields.py
index a6b82807be9..63326ab63c5 100644
--- a/addons/snailmail/wizard/snailmail_letter_missing_required_fields.py
+++ b/addons/snailmail/wizard/snailmail_letter_missing_required_fields.py
@@ -31,11 +31,9 @@ class SnailmailLetterMissingRequiredFields(models.TransientModel):
})
return rec
- @api.multi
def update_address_cancel(self):
self.letter_id.cancel()
- @api.multi
def update_address_save(self):
address_data = {
'street': self.street,